Resolve an issue where the AllowExternalTraffic configuration was not set to its default value #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating the configuration, we are fetching this value using `viper.GetString()`, which expect a string value (rather than enum), so we must set it as string as well.
zohar7ch
changed the title
AllowExternalTraffic
omris94
approved these changes
Feb 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing setting the initial value of
AllowExternalTrafficconfiguration when there is no value in the helm file.Technical details:
When creating the configuration, we are fetching this value using
viper.GetString(), which expect a string value (rather than enum), so we must set it as string as well.Testing
Tested locally by running the intents operator and making sure that it reports values to Otterize cloud..
Checklist