Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed golangci-lint errors that happened during the CI because of an old github-actions version #563

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

zohar7ch
Copy link
Contributor

@zohar7ch zohar7ch commented Feb 13, 2025

Description

Upgrade the version of golangci-lint github action. The old version used to cause unrelated errors during the CI, and according to this thread (golangci/golangci-lint-action#135) the issue is fixed in a newer version (v6)

  • This change adds test coverage for new/changed/fixed functionality
  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

The old version used to cause errors, and according to this thread
(golangci/golangci-lint-action#135) the error
is fixe din v6
@zohar7ch zohar7ch force-pushed the zohar7ch/change-linter-settings branch from 2a26030 to da8f0a3 Compare February 13, 2025 13:55
@zohar7ch zohar7ch changed the title Test new lint Bump the linter github action, to caused errors during the CI Feb 13, 2025
@zohar7ch zohar7ch requested a review from omris94 February 13, 2025 13:57
@zohar7ch zohar7ch changed the title Bump the linter github action, to caused errors during the CI Bump the linter github action, to fix errors that occurred during the CI Feb 13, 2025
@zohar7ch zohar7ch changed the title Bump the linter github action, to fix errors that occurred during the CI Bump lint github action, to fix errors that occurred during the CI Feb 13, 2025
@zohar7ch zohar7ch changed the title Bump lint github action, to fix errors that occurred during the CI Update the golangci-lint- github action Feb 13, 2025
@zohar7ch zohar7ch changed the title Update the golangci-lint- github action Fixed golangci-lint error that happened during the CI because of an old github-actions version Feb 13, 2025
@zohar7ch zohar7ch changed the title Fixed golangci-lint error that happened during the CI because of an old github-actions version Fixed golangci-lint errors that happened during the CI because of an old github-actions version Feb 13, 2025
@zohar7ch zohar7ch merged commit d655a22 into main Feb 13, 2025
20 checks passed
@zohar7ch zohar7ch deleted the zohar7ch/change-linter-settings branch February 13, 2025 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants