Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6790 Raise 404 when attempting to edit pseud that doesn't exist #5046

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lou-codes
Copy link
Contributor

@lou-codes lou-codes commented Feb 2, 2025

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6790

Purpose

When navigating to an edit page for a pseud that doesn't exist (/users/valid_user/pseuds/fake_pseud/edit), we should return a 404 error

Testing Instructions

Steps to reproduce, from JIRA:

User

  1. Log in
  2. Attempt to access the edit pseud page for a nonexistent pseud on your account. For example, if you are logged in as testy and don't have a pseud named annoying_error, enter the following URL in your browser: https://test.archiveofourown.org/users/testy/pseuds/annoying_error/edit

Admin

  1. Log in as an admin who can edit pseuds (policy_and_abuse or superadmin)
  2. Attempt to access the edit pseud page for a nonexistent pseud on an existing user. For example, if the user testy exists but doesn't have a pseud annoying_error, enter the following URL in your browser: https://test.archiveofourown.org/users/testy/pseuds/annoying_error/edit will give a 500 error

References

Are there other relevant issues/pull requests/mailing list discussions?
Similar to linked ticket AO3-6791 to give 404 when the user doesn't exist, PR here

Credit

lou (she/her)

@lou-codes lou-codes marked this pull request as ready for review February 3, 2025 00:27
Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Just a note, you don't have to copy the testing instructions from the Jira issue, it's fine to just put something like "Refer to Jira" into that section in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants