Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6904 Set passwords of testuser and testadmin in fixtures to known values #5064

Merged

Conversation

chazfg
Copy link
Contributor

@chazfg chazfg commented Feb 14, 2025

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6904

Purpose

This PR modifies two fixture entries: admins.yml and users.yml. In each, one of the users has their encrypted password changed from the hash to a function that allows the password to be read in plaintext.

Credit

CJ G

@github-actions github-actions bot added Scope: Tests Only Only changes automated tests or test configuration Awaiting Review labels Feb 14, 2025
Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, CJ G!

Thanks for the pull request! Everything looks good to me, so I have approved the PR. We will merge it once we schedule this ticket for release.

In the meantime, I've updated the Jira issue status to In Review so no one will mistakenly create a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! You can just reply here with the account name and we'll set up the permissions for you. (It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME).")

Thank you again for contributing! If you have any questions, you can contact us at [email protected].

@chazfg
Copy link
Contributor Author

chazfg commented Feb 14, 2025

Hey Brian, thanks so much. I just made a Jira account with my email [email protected]. Then too you might as well use CJ Gorey as the credit name as well.

@brianjaustin brianjaustin merged commit 124ae76 into otwcode:master Feb 15, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed: Ready to Merge Scope: Tests Only Only changes automated tests or test configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants