Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for manager v2 #428

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Add support for manager v2 #428

merged 1 commit into from
Jan 22, 2024

Conversation

neokry
Copy link
Collaborator

@neokry neokry commented Jan 22, 2024 •
edited
Loading

Description

Adds support for the V2 manager.

Code review

  • Ensure creating DAOs continues to work

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have done a self-review of my own code
  • Any new and existing tests pass locally with my changes
  • My changes generate no new warnings (lint warnings, console warnings, etc)

@vercel Vercel
Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nouns-builder ✅ Ready (Inspect) Visit Preview Jan 22, 2024 6:05pm
testnet-nouns-builder ✅ Ready (Inspect) Visit Preview Jan 22, 2024 6:05pm

@isaaczaak isaaczaak self-requested a review January 22, 2024 18:42
@neokry neokry merged commit f289d56 into main Jan 22, 2024
2 of 3 checks passed
@neokry neokry deleted the support-manager-v2 branch January 22, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaaczaak isaaczaak isaaczaak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neokry @isaaczaak