Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Collection Offers v1.0 #125

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[feat] Collection Offers v1.0 #125

wants to merge 14 commits into from
+1,945 −0

Commits on Jan 25, 2022

  1. [feat] Collection Offers v1.0

    Rohan Kulkarni committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    469faf1 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. [feat] update for community review

    Rohan Kulkarni committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    f943878 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into collection-offers

    Rohan Kulkarni committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    78ce19a View commit details
    Browse the repository at this point in the history

  3. snapshot

    @joshieDo
    joshieDo committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    e3cb5a3 View commit details
    Browse the repository at this point in the history

  4. no need for uint32 on createOffers

    @joshieDo
    joshieDo committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    b5bd260 View commit details
    Browse the repository at this point in the history

  5. use uint32 only for storage

    @joshieDo
    joshieDo committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    ddb8b45 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. _offerCount to save sloads

    @joshieDo
    joshieDo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    65e8d93 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Merge branch 'main' into collection-offers

    Rohan Kulkarni committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    bd2daaf View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. Merge pull request #143 from joshieDo/changes 

    [feat] golf from @joshieDo
    @kulkarohan
    kulkarohan authored Feb 28, 2022
    Configuration menu
    Copy the full SHA
    f4a66d3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'collection-offers' of https://github.com/ourzora/v3 int… 

    …o collection-offers
    Rohan Kulkarni committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    7c3d955 View commit details
    Browse the repository at this point in the history

  3. [fix] add gas limit

    Rohan Kulkarni committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    1cfeb54 View commit details
    Browse the repository at this point in the history

  4. [fix] events param id -> offerId

    Rohan Kulkarni committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    ebbebd4 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. test: add assertions when protocol fee is non-zero

    @almndbtr
    almndbtr authored Mar 1, 2022
    Configuration menu
    Copy the full SHA
    4e6b08a View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2022

  1. Merge pull request #144 from almndbtr/collection-offers-nonzero-proto… 

    …col-fee

Collection Offers v1.0: add tests when the protocol fee is non-zero
    @kulkarohan
    kulkarohan authored Mar 3, 2022
    Configuration menu
    Copy the full SHA
    04f674b View commit details
    Browse the repository at this point in the history