-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate code to make contract fit #145
Conversation
@@ -1,7 +1,7 @@ | |||
[profile.default] | |||
solc_version = '0.8.17' | |||
optimizer = true | |||
optimizer_runs = 300 | |||
optimizer_runs = 500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
@@ -51,7 +51,11 @@ | |||
}, | |||
"dependencies": { | |||
"@dotenv/cli": "^2.2.2", | |||
<<<<<<< HEAD | |||
"@zoralabs/protocol-rewards": "^1.0.1", | |||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken rebase
_emitSaleEvents(msgSender, msgSender, quantity, pricePerToken, firstMintedTokenId, comment); | ||
|
||
return firstMintedTokenId; | ||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken rebase :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was trying to get this diff better, didn't work, ignore for now
@@ -452,7 +452,7 @@ contract ERC721Drop is | |||
onlyPublicSaleActive | |||
returns (uint256) | |||
{ | |||
return _handlePurchase(msg.sender, quantity, ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this _handlePurchase function?
Moving to a new diff. |
No description provided.