Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add helper to read uups implementation #206

Merged
merged 9 commits into from
Sep 27, 2023
Merged

Conversation

kulkarohan
Copy link
Contributor

No description provided.

@kulkarohan
Copy link
Contributor Author

kulkarohan commented Sep 27, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@@ -64,7 +64,7 @@ contract UpgradeScript is ZoraDeployerBase {

deployment.factoryProxy = address(
new ZoraCreator1155FactoryImpl({
_implementation: IZoraCreator1155(deployment.contract1155Impl),
_zora1155Impl: IZoraCreator1155(deployment.contract1155Impl),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice rename 👍

@kulkarohan kulkarohan merged commit 395cd25 into premint Sep 27, 2023
7 checks passed
@kulkarohan kulkarohan deleted the add_uups_helper branch September 27, 2023 20:19
@oveddan oveddan mentioned this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants