Deploy premint v2 to zora goerli and zora sepolia. Simulate and give instruactions for premint upgrades #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Closed
oveddan
force-pushed
the
bump-premint-version
branch
from
76d2337
to
e4b8819
Compare
oveddan
force-pushed
the
deploy-premint-v2
branch
from
155002a
to
8c57238
Compare
oveddan
force-pushed
the
bump-premint-version
branch
from
e4b8819
to
e95ac50
Compare
oveddan
force-pushed
the
deploy-premint-v2
branch
from
bb941a0
to
16c46c0
Compare
oveddan
changed the title
kulkarohan
previously approved these changes
Nov 21, 2023
|
lgtm! thoughts on moving all deploy-related files (eg. |
i can see the need for that, but i feel they are more like classes than scrips, and everything in |
oveddan
force-pushed
the
deploy-premint-v2
branch
from
2b566c3
to
c864029
Compare
|
already approved, just approval got lost in rebase. merging. |
iainnash
pushed a commit
that referenced
this pull request
Jan 5, 2024
…instruactions for premint upgrades (#378) * updated deployment scripts to not fail if determinstic address not already created * improvements on deploy * deployed 2.5.1 to zora sepolia * clean up test * added a test contract deployer * deploy to zora goerli * making sure to stop prank * fix upgrade test * updated changeset * remove upgrade needed log
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
…instruactions for premint upgrades (#378) * updated deployment scripts to not fail if determinstic address not already created * improvements on deploy * deployed 2.5.1 to zora sepolia * clean up test * added a test contract deployer * deploy to zora goerli * making sure to stop prank * fix upgrade test * updated changeset * remove upgrade needed log
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
…instruactions for premint upgrades (#378) * updated deployment scripts to not fail if determinstic address not already created * improvements on deploy * deployed 2.5.1 to zora sepolia * clean up test * added a test contract deployer * deploy to zora goerli * making sure to stop prank * fix upgrade test * updated changeset * remove upgrade needed log
oveddan
added a commit
that referenced
this pull request
Jul 15, 2024
* draft: Zora Account Manager * cleanup pr --------- Co-authored-by: Dan Oved <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we now can get this output in tests: