Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't label Bliptext links as external links #28

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ZakaHaceCosas
Copy link

simple change, should work

fixes #25

Copy link

@GroppyYT GroppyYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@face-hh
Copy link
Member

face-hh commented Feb 15, 2025

Will look into this later this month

Copy link

@Assassin-1234 Assassin-1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Contributor

@Sakura-sx Sakura-sx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to
.startsWith("https://bliptext.com/")
instead of
.startsWith("https://bliptext.com")

The issue is that https://bliptext.com.voxga.es would be allowed, or https://bliptext.comeon.com would also be allowed, as they start with "https://bliptext.com".

@Sakura-sx
Copy link
Contributor

fixes #43

@ZakaHaceCosas
Copy link
Author

ZakaHaceCosas commented Feb 27, 2025

Sure, I'll remove the trailing / , and I guess I can .split(".") the URL and see if its length is greater than two (because a normal bliptext url can only be ["bliptext", "com/whatever"] ) to avoid weird URLs
I'll change that as soon as I get home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bliptext links are labeled as external links
5 participants