fix(sql) fix ready for query state #17272
Merged
+8
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix: #17178
Fix: #16691
After investigating was discovered that supabase returns an additional ParameterStatus with value "S\x00\x00\x00\x1fapplication_name\x00Supavisor\x00" informing the application name, with makes we mark the connection as
is_ready_for_query = false
when we should not, we only need to mark asis_ready_for_query = false
when writting .Sync.In the case of the Issue
16691
the connection was in a broken state until the server closed it, but the cause wasis_ready_for_query
was false when should not be.How did you verify your code works?
Manually