Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql) fix ready for query state #17272

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Feb 12, 2025

What does this PR do?

Fix: #17178
Fix: #16691

After investigating was discovered that supabase returns an additional ParameterStatus with value "S\x00\x00\x00\x1fapplication_name\x00Supavisor\x00" informing the application name, with makes we mark the connection as is_ready_for_query = false when we should not, we only need to mark as is_ready_for_query = false when writting .Sync.

In the case of the Issue 16691 the connection was in a broken state until the server closed it, but the cause was is_ready_for_query was false when should not be.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Manually

@robobun
Copy link

robobun commented Feb 12, 2025

Updated 5:39 PM PT - Feb 11th, 2025

@cirospaciari, your commit 11c63c2 has 2 failures in Build #11465:


🧪   try this PR locally:

bunx bun-pr 17272

@cirospaciari cirospaciari force-pushed the ciro/fix-postgres-ready-for-query branch from 9f39250 to 11c63c2 Compare February 12, 2025 00:41
@Jarred-Sumner Jarred-Sumner merged commit 7403088 into main Feb 12, 2025
55 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-postgres-ready-for-query branch February 12, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL: loses connection after timeout ERR_POSTGRES_CONNECTION_CLOSED
3 participants