Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Testing and Linting #13

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Feat: Testing and Linting #13

merged 5 commits into from
Nov 21, 2023

Conversation

CodeWithEmad
Copy link
Member

Assorted testing and linting improvements:

  • Makefile with test and lint targets
  • Long lines reformated with black
  • Sort imports with isort

In addition:

  • Typing added for various functions

@CodeWithEmad CodeWithEmad mentioned this pull request Nov 18, 2023
Closed
@regisb regisb self-requested a review November 21, 2023 07:48
@regisb regisb self-assigned this Nov 21, 2023
regisb
regisb approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@regisb
Copy link
Contributor

regisb commented Nov 21, 2023

Can you please rebase your PR on top of master?

@regisb regisb assigned CodeWithEmad and unassigned regisb Nov 21, 2023
@CodeWithEmad
Copy link
Member Author

Done!

@regisb regisb merged commit df108fd into overhangio:master Nov 21, 2023
1 check passed
@CodeWithEmad CodeWithEmad deleted the feat/test-lint branch November 21, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisb regisb regisb approved these changes

Assignees

@CodeWithEmad CodeWithEmad

Labels
None yet
Projects
Tutor project management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeWithEmad @regisb