Keeshii's script editor #1194
Open
Keeshii's script editor #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store entity-scripts in the asset server
ksuprynowicz
added
enhancement
interface/CMakeLists.txt
Outdated
| @@ -37,6 +40,24 @@ if (BUILD_TOOLS AND JSDOC_ENABLED) | |||
| add_custom_qrc_path(CUSTOM_INTERFACE_QRC_PATHS "${CMAKE_BINARY_DIR}/tools/jsdoc/out/hifiJSDoc.json" "auto-complete/hifiJSDoc.json") | |||
| endif () | |||
|
|
|||
| FetchContent_Declare( | |||
There was a problem hiding this comment.
I think it would be cleaner to move this to cmake/externals and then include it here
There was a problem hiding this comment.
It's a very good idea, as long as it would still be FetchContent - we need the files to be available during the cmake configuration process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR for Keeshii's script editor. Built Angular project is an external dependency in this version.
We still needs to fix the issue where script editor fails to connect and add support for getting script errors and messages from recently added metods like
Script.errorEntityMessage.