Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing properties in Script API #1215

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

ksuprynowicz
Copy link
Member

Script.context, Script.type and Script.fileName was missing after move to V8. Already tested just needs review.
Needed by script editor PR.

@ksuprynowicz ksuprynowicz added bug Something isn't working needs CR This pull request needs to be code reviewed labels Oct 31, 2024
@HifiExperiments HifiExperiments added CR approved This pull request has been successfully code reviewed and removed needs CR This pull request needs to be code reviewed labels Oct 31, 2024
@ksuprynowicz ksuprynowicz merged commit 9d15fc4 into master Nov 1, 2024
7 checks passed
@ksuprynowicz ksuprynowicz deleted the fix/script_context_prop branch November 1, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CR approved This pull request has been successfully code reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants