Read gltf copyright #264
Open
Read gltf copyright #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daleglass
force-pushed
the
read-gltf-copyright
branch
from
68e8a48
to
44adf97
Compare
|
Rebased on master. I looked a bit at the code. The model's application name is checked internally for FBX files, for some special handling for files coming from mixamo.com This needs a bit more work to actually expose it to the API. |
daleglass
added
needs CR
ksuprynowicz
previously approved these changes
May 1, 2023
ksuprynowicz
added
CR approved
ksuprynowicz
dismissed
their stale review
I should read comments first. It looks like this is still work in progress.
ksuprynowicz
added
work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May help with #262
It's a trivial change that copies the copyright info embedded in GLTF into the model object. Not really good for anything just yet, but this data could be exposed to the end user. An useful thing about it is that this metadata exists without needing an FST.