-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Floofchat with ArmoredChat #961
Conversation
Floof Chat moved to script archive. Fixed local message distance check. Signed-off-by: Armored Dragon <[email protected]>
Erase messages. Toggle external window. Signed-off-by: Armored Dragon <[email protected]>
Signed-off-by: Armored Dragon <[email protected]>
Settings now initialize properly. Settings now save properly. Removed compact_chat setting as deprecated. Added spacing between settings. Message history now prunes itself if the number of messages exceeds maximum. Signed-off-by: Armored Dragon <[email protected]>
Hotfix for empty message_history setting. Signed-off-by: Armored Dragon <[email protected]>
Messages are now rich text. Fix clear_message command flow over. Signed-off-by: Armored Dragon <[email protected]>
Hopefully makes code pasting easier. Added missing break to prevent unintended executions. Signed-off-by: Armored Dragon <[email protected]>
Allows for kinetic mouse scrolling. Signed-off-by: Armored Dragon <[email protected]>
Signed-off-by: Armored Dragon <[email protected]>
Disabled sending on Shift + Enter to prevent confusion. Signed-off-by: Armored Dragon <[email protected]>
Despite my best efforts I have not found a reliable way to impliment "Selective auto-scroll". For reviewers:
|
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Armored Dragon <[email protected]>
Signed-off-by: Armored Dragon <[email protected]>
Resolved "listview" rendering warnings. Prevent sending empty messages. Signed-off-by: Armored Dragon <[email protected]>
Signed-off-by: Armored Dragon <[email protected]>
Signed-off-by: Armored Dragon <[email protected]>
Document image embedding. Declared notificationCore as dependency. Signed-off-by: Armored Dragon <[email protected]>
Updated systemchat html script path. Renamed "chat" to "floofChat" to avoid confusion. Signed-off-by: Armored Dragon <[email protected]>
More documentation on link related features. Signed-off-by: Armored Dragon <[email protected]>
Here is a list of tasks to do gathered from QA testing:
|
VR keyboard does not show up |
Signed-off-by: Armored Dragon <[email protected]>
Signed-off-by: Armored Dragon <[email protected]>
It also looks like the messages from Floof Chat are not being received. We could drop Floof Chat compatibility later, but having no compatibility in initial version will cause problems since some people will be running stable version and some will be running development builds. |
Made conversion functions to allow communication between apps. Removed developer console.log function. Signed-off-by: Armored Dragon <[email protected]>
I've restored compatibility with floofchat in 192d80a, I'm hoping the the future we can toss the compatibility. Maybe after the next release? |
Sure! That's a very good idea |
This comment was marked as outdated.
This comment was marked as outdated.
I will try to look at VR keyboard issue this weekend |
Signed-off-by: Armored Dragon <[email protected]>
Signed-off-by: Armored Dragon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost everything looks good, although there's one thing that we should test thoroughly to make sure it's not a security vulnerability that could allow arbitrary JS code execution with QML priviledges.
Removed now redundant <script> filtering. Signed-off-by: Armored Dragon <[email protected]>
Signed-off-by: Armored Dragon <[email protected]>
I found such exception somehow just now, but I have trouble repeating it:
|
I also noticed that messages from FloofChat don't show up. |
This seems to occur using the alternate chat application. Really any other chat application other than floofchat (also excluding this chat app of course) will cause this issue. I will put in a sanity check. |
Signed-off-by: Armored Dragon <[email protected]>
Signed-off-by: Armored Dragon <[email protected]>
Replace Floofchat with a smaller application using written in QML.
Compatibility
This version of Armored Chat is not compatible with Floofchat.
Armored Chat is still compatible with notificationCore.js.
Linked issues and pulls
Merge with overte-org/community-apps#79.
Part of #886.
Closes #898 as complete.
Closes #778 as irrelevant.
Closes #922 as irrelevant.
Closes #975 as irrelevant.
Todo:
Selective auto-scroll