Skip to content

Commit

Permalink
fix(datagrid): typo
Browse files Browse the repository at this point in the history
  • Loading branch information
aesteves60 committed Oct 2, 2023
1 parent bed0405 commit 329bd36
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ describe('e2e:osds-datagrid', () => {
expect(table).not.toBeNull();
});

it('sould render 1 rows & 2 columns', async () => {
it('should render 1 rows & 2 columns', async () => {
await setup({ attributes: {
columns: JSON.stringify([{ title: 'Name', field: 'name' }, { title: 'Firstname', field: 'firstname' }]),
rows: JSON.stringify([{ name: 'Homer', firstname: 'Simpson' }]),
}});
} });
const columns = await table?.findAll('.tabulator-col');
expect(columns).toHaveLength(2);
expect(columns?.[0].innerText).toContain('Name');
Expand All @@ -45,11 +45,11 @@ describe('e2e:osds-datagrid', () => {
expect(rows?.[0].innerText).toContain('HomerSimpson');
})

it('sould update rows', async () => {
it('should update rows', async () => {
await setup({ attributes: {
columns: JSON.stringify([{ title: 'Name', field: 'name' }, { title: 'Firstname', field: 'firstname' }]),
rows: JSON.stringify([{ name: 'Homer', firstname: 'Simpson' }]),
}});
} });
el.setProperty('rows', JSON.stringify([
{ name: 'Homer', firstname: 'Simpson' },
{ name: 'Marge', firstname: 'Simpson' },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { OdsLogger } from '@ovhcloud/ods-common-core';
})
export class OsdsDatagrid implements OdsDatagridAttribute {
private readonly controler = new OdsDatagridController(this);
readonly logger = new OdsLogger('OsdsPhoneNumber');
readonly logger = new OdsLogger('OsdsDatagrid');
private grid?: HTMLDivElement;
private table?: Tabulator;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Meta } from '@storybook/addon-docs';
import SpecificationsContentAddon from '@ovhcloud/ods-components/datagrid/documentation/specifications/specifications-datagrid.mdx';

<Meta title="UI Components/Datagrid [molecule]/Specifications" />
<Meta title="UI Components/Datagrid [organism]/Specifications" />

# Datagrid - Technical Specification
----
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Description, Meta } from '@storybook/addon-docs';
import APITable from '@ovhcloud/ods-components/datagrid/dist/docs/components/osds-datagrid/readme.md';
import Usage from '@ovhcloud/ods-components/datagrid/src/docs/osds-datagrid/usage.mdx';

<Meta title="UI Components/Datagrid [molecule]/Web Component" />
<Meta title="UI Components/Datagrid [organism]/Web Component" />

# `<osds-datagrid columns="'[{...}]'" rows="'[{...}]'"></osds-datagrid>`

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const defaultStoryParams = {
};

export default {
title: 'UI Components/Datagrid [molecule]/Web Component',
title: 'UI Components/Datagrid [organism]/Web Component',
id: 'datagrid',
parameters: {
notes: {
Expand Down

0 comments on commit 329bd36

Please sign in to comment.