merge: revert of manager-react-components build and publish

Signed-off-by: Anoop N <[email protected]>
ovh · Oct 24, 2024 · 1b6dfee · 1b6dfee
2 parents fc9d66d + 93c6fb7
commit 1b6dfee
Show file tree

Hide file tree

Showing 185 changed files with 608 additions and 1,971 deletions.
diff --git a/.github/workflows/run-bdd-tests.yml b/.github/workflows/run-bdd-tests.yml
@@ -21,7 +21,7 @@ jobs:
       - name: Build BDD covered packages and dependencies
         run: |
           yarn exec turbo -- run build --filter="./packages/manager/core/*" --concurrency=5
-          yarn exec turbo -- run build --filter="./packages/manager-react-components" --concurrency=5
+          yarn exec turbo -- run build --filter="./packages/manager/manager-components/*" --concurrency=5
           yarn exec turbo -- run build --filter="./packages/manager/modules/order" --concurrency=5
       # This task is for running the jest tests outside microApps
       - name: Run tests Jest

diff --git a/.sonarcloud.properties b/.sonarcloud.properties
@@ -7,7 +7,7 @@ sonar.projectName=manager
 sonar.sources=.
 sonar.sourceEncoding=UTF-8
 sonar.ws.timeout=60
-sonar.projectVersion=radon-sheep-2
+sonar.projectVersion=radon-sheep
 
 sonar.exclusions=node_modules/**, **/node_modules/**, **/dist/**, **/semantic/**, **/coverage/**, **/static/**, **/mock/**, **/mockServiceWorker.js
 sonar.coverage.exclusions=**/*.spec.js

diff --git a/packages/components/ng-at-internet/CHANGELOG.md b/packages/components/ng-at-internet/CHANGELOG.md
@@ -3,22 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [5.11.16-alpha.1](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-24)
-
-**Note:** Version bump only for package @ovh-ux/ng-at-internet
-
-
-
-
-
-## [5.11.16-alpha.0](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-24)
-
-**Note:** Version bump only for package @ovh-ux/ng-at-internet
-
-
-
-
-
 ## [5.11.15](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-22)
 
 **Note:** Version bump only for package @ovh-ux/ng-at-internet

diff --git a/packages/components/ng-at-internet/package.json b/packages/components/ng-at-internet/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ovh-ux/ng-at-internet",
-  "version": "5.11.16-alpha.1",
+  "version": "5.11.15",
   "private": true,
   "description": "ATInternet tracking library wrapper for AngularJS",
   "keywords": [
@@ -36,7 +36,7 @@
     "start:watch": "lerna exec --stream --parallel --scope='@ovh-ux/ng-at-internet' --include-dependencies -- yarn run dev:watch"
   },
   "dependencies": {
-    "@ovh-ux/ovh-at-internet": "^0.15.1-alpha.1"
+    "@ovh-ux/ovh-at-internet": "^0.15.0"
   },
   "devDependencies": {
     "@ovh-ux/component-rollup-config": "^13.0.1"

diff --git a/packages/components/ng-shell-tracking/CHANGELOG.md b/packages/components/ng-shell-tracking/CHANGELOG.md
@@ -3,22 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [0.5.13-alpha.1](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-24)
-
-**Note:** Version bump only for package @ovh-ux/ng-shell-tracking
-
-
-
-
-
-## [0.5.13-alpha.0](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-24)
-
-**Note:** Version bump only for package @ovh-ux/ng-shell-tracking
-
-
-
-
-
 ## [0.5.12](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-22)
 
 **Note:** Version bump only for package @ovh-ux/ng-shell-tracking

diff --git a/packages/components/ng-shell-tracking/package.json b/packages/components/ng-shell-tracking/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ovh-ux/ng-shell-tracking",
-  "version": "0.5.13-alpha.1",
+  "version": "0.5.12",
   "private": true,
   "description": "ATInternet tracking library wrapper for AngularJS",
   "keywords": [
@@ -37,7 +37,7 @@
     "start:watch": "lerna exec --stream --parallel --scope='@ovh-ux/ng-shell-tracking' --include-dependencies -- yarn run dev:watch"
   },
   "dependencies": {
-    "@ovh-ux/ovh-at-internet": "^0.15.1-alpha.1"
+    "@ovh-ux/ovh-at-internet": "^0.15.0"
   },
   "devDependencies": {
     "@ovh-ux/component-rollup-config": "^13.0.1"

diff --git a/packages/components/ovh-at-internet/CHANGELOG.md b/packages/components/ovh-at-internet/CHANGELOG.md
@@ -3,22 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [0.15.1-alpha.1](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-24)
-
-**Note:** Version bump only for package @ovh-ux/ovh-at-internet
-
-
-
-
-
-## [0.15.1-alpha.0](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-24)
-
-**Note:** Version bump only for package @ovh-ux/ovh-at-internet
-
-
-
-
-
 # [0.15.0](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-22)
 
 

diff --git a/packages/components/ovh-at-internet/package.json b/packages/components/ovh-at-internet/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ovh-ux/ovh-at-internet",
-  "version": "0.15.1-alpha.1",
+  "version": "0.15.0",
   "private": true,
   "description": "ATInternet tracking library for OVHcloud.",
   "keywords": [
@@ -35,7 +35,7 @@
     "start:watch": "lerna exec --stream --parallel --scope='@ovh-ux/manager-config' --include-dependencies -- yarn run dev:watch"
   },
   "dependencies": {
-    "@ovh-ux/manager-config": "^7.5.1-alpha.1",
+    "@ovh-ux/manager-config": "^7.5.0",
     "@types/lodash-es": "^4.17.5",
     "lodash-es": "^4.17.15"
   }

diff --git a/packages/components/ovh-shell/CHANGELOG.md b/packages/components/ovh-shell/CHANGELOG.md
@@ -3,25 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-# [3.11.0-alpha.1](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-24)
-
-**Note:** Version bump only for package @ovh-ux/shell
-
-
-
-
-
-# [3.11.0-alpha.0](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-24)
-
-
-### Features
-
-* **manager-react-components:** build manager react components lib ([3ffbfea](https://github.com/ovh/manager/commit/3ffbfeac1e0364917ae6c93f90b392bd1ee6603c))
-
-
-
-
-
 # [3.10.0](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-22)
 
 

diff --git a/packages/components/ovh-shell/package.json b/packages/components/ovh-shell/package.json
@@ -1,6 +1,7 @@
 {
   "name": "@ovh-ux/shell",
-  "version": "3.11.0-alpha.1",
+  "version": "3.10.0",
+  "private": true,
   "description": "Communication and interaction between applications",
   "repository": {
     "type": "git",
@@ -17,17 +18,16 @@
     "build": "tsc",
     "dev": "tsc",
     "dev:watch": "tsc -w",
-    "prepare": "tsc",
     "start": "lerna exec --stream --scope='@ovh-ux/shell' --include-dependencies -- npm run build --if-present",
     "start:dev": "lerna exec --stream --scope='@ovh-ux/shell' --include-dependencies -- npm run dev --if-present",
     "start:watch": "lerna exec --stream --parallel --scope='@ovh-ux/shell' --include-dependencies -- npm run dev:watch --if-present"
   },
   "dependencies": {
-    "@ovh-ux/manager-config": "^7.5.1-alpha.1",
-    "@ovh-ux/ovh-at-internet": "^0.15.1-alpha.1",
-    "@ovh-ux/ovh-reket": "^2.1.3",
-    "@ovh-ux/request-tagger": "^0.4.0-alpha.0",
-    "@ovh-ux/url-builder": "^1.3.0-alpha.0",
+    "@ovh-ux/manager-config": "^7.5.0",
+    "@ovh-ux/ovh-at-internet": "^0.15.0",
+    "@ovh-ux/ovh-reket": "^2.1.2",
+    "@ovh-ux/request-tagger": "^0.3.0",
+    "@ovh-ux/url-builder": "^1.2.0",
     "@types/react": "^18.0.0",
     "dompurify": "^2.3.3",
     "jest-cucumber": "^3.0.1",

diff --git a/packages/manager-react-components/.storybook/preview.tsx b/packages/manager-react-components/.storybook/preview.tsx
@@ -5,7 +5,6 @@ import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
 
 import { Preview } from '@storybook/react';
 import '../src/tailwind/theme.css';
-import '../src/index.css';
 import i18n from './i18n';
 
 import '@ovhcloud/ods-theme-blue-jeans';

diff --git a/packages/manager-react-components/CHANGELOG.md b/packages/manager-react-components/CHANGELOG.md
@@ -3,18 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-# [1.40.0-alpha.1](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-24)
-
-### Features
-
-- **pci-workflow:** add resource selector datagrid ([96a6a88](https://github.com/ovh/manager/commit/96a6a8811cd4502d32dffc6f2d8b9395bea982ea))
-
-# [1.40.0-alpha.0](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-24)
-
-### Features
-
-- **manager-react-components:** build manager react components lib ([3ffbfea](https://github.com/ovh/manager/commit/3ffbfeac1e0364917ae6c93f90b392bd1ee6603c))
-
 ## [1.39.1](https://github.com/ovh/manager/compare/@ovh-ux/[email protected]...@ovh-ux/[email protected]) (2024-10-22)
 
 **Note:** Version bump only for package @ovh-ux/manager-react-components

diff --git a/packages/manager-react-components/package.json b/packages/manager-react-components/package.json
@@ -1,28 +1,17 @@
 {
   "name": "@ovh-ux/manager-react-components",
-  "version": "1.40.0-alpha.1",
-  "license": "BSD-3-Clause",
-  "author": "OVH SAS",
-  "types": "dist/types/src/lib.d.ts",
-  "main": "dist/src/lib.js",
-  "browser": "dist/manager-react-components-lib.es.ts",
-  "homepage": "https://github.com/ovh/manager/blob/master/packages/manager-react-components/README.md",
-  "bugs": {
-    "url": "https://github.com/ovh/manager/issues"
-  },
+  "version": "1.39.1",
+  "main": "src/lib.ts",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/ovh/manager.git",
     "directory": "packages/manager-react-components"
   },
-  "files": [
-    "dist"
-  ],
+  "ignoreDependencies": true,
   "scripts": {
-    "build": "vite build && tsc",
-    "dev": "vite build && tsc",
+    "build": "echo build",
     "build:storybook": "storybook build",
-    "prepare": "vite build && tsc",
+    "dev": "tsc",
     "prettier": "prettier --write \"src/**/*.{ts,tsx,js,mdx}\"",
     "start": "storybook dev -p 6006",
     "test": "jest --coverage -u",
@@ -37,8 +26,8 @@
   },
   "dependencies": {
     "@babel/plugin-proposal-private-property-in-object": "^7.21.11",
-    "@ovh-ux/manager-core-api": "^0.8.1-alpha.1",
-    "@ovh-ux/manager-react-shell-client": "^0.8.0-alpha.1",
+    "@ovh-ux/manager-core-api": "^0.8.0",
+    "@ovh-ux/manager-react-shell-client": "^0.7.5",
     "@ovhcloud/ods-common-core": "17.2.2",
     "@ovhcloud/ods-common-theming": "17.2.2",
     "@ovhcloud/ods-components": "17.2.2",
@@ -116,7 +105,6 @@
     "undici": "5.28.4",
     "vite": "^5.2.13",
     "vite-plugin-dts": "3.5.1",
-    "vite-plugin-static-copy": "^2.0.0",
     "vitest": "^1.2.0",
     "zustand": "^4.5.0"
   },

diff --git a/packages/manager-react-components/src/components/table/table.component.tsx b/packages/manager-react-components/src/components/table/table.component.tsx
@@ -1,4 +1,5 @@
 import React, { PropsWithChildren } from 'react';
+import style from './table.module.scss';
 
 export type TableProps = PropsWithChildren<{
   fullWidth?: boolean;
@@ -11,7 +12,7 @@ export const Table: React.FC<TableProps> = ({
   cellSpacing = 0,
 }) => (
   <table
-    className={`${fullWidth ? 'w-full' : ''} manager-table`}
+    className={`${style.table} ${fullWidth ? 'w-full' : ''}`}
     cellSpacing={cellSpacing}
   >
     {children}

diff --git a/packages/manager-react-components/src/components/table/table.module.scss b/packages/manager-react-components/src/components/table/table.module.scss
@@ -0,0 +1,20 @@
+.table {
+  th {
+    padding: 1rem 1rem;
+    border-bottom: solid 1px var(--ods-color-blue-200);
+  }
+  tbody {
+    td {
+      padding: 1rem 1rem;
+      border-bottom: solid 1px var(--ods-color-blue-200);
+    }
+
+    td:first-child {
+      border-left: solid 1px var(--ods-color-blue-200);
+    }
+
+    td:last-child {
+      border-right: solid 1px var(--ods-color-blue-200);
+    }
+  }
+}
diff --git a/...nents/public/assets/error-banner-oops.png → ...plates/error/assets/error-banner-oops.png b/...nents/public/assets/error-banner-oops.png → ...plates/error/assets/error-banner-oops.png
diff --git a/packages/manager-react-components/src/components/templates/error/error.component.tsx b/packages/manager-react-components/src/components/templates/error/error.component.tsx
@@ -12,12 +12,11 @@ import {
   ODS_BUTTON_VARIANT,
 } from '@ovhcloud/ods-components';
 import './translations/translations';
+import OOPS from './assets/error-banner-oops.png';
 
 import { ErrorBannerProps } from './error.types';
 import { useTranslation } from 'react-i18next';
 
-import ErrorImg from '../../../../public/assets/error-banner-oops.png';
-
 export const ErrorBanner = ({
   error,
   onRedirectHome,
@@ -28,7 +27,7 @@ export const ErrorBanner = ({
 
   return (
     <div className="mx-auto  w-full h-full max-w-[600px] overflow-hidden mx-autogrid p-5">
-      <img src={ErrorImg} alt="OOPS" className="w-full" />
+      <img src={OOPS} alt="OOPS" className="w-full" />
       <div className="py-2">
         <OsdsText size={ODS_TEXT_SIZE._600} level={ODS_TEXT_LEVEL.heading}>
           {t('manager_error_page_title')}

diff --git a/...-components/public/assets/placeholder.png → ...mplates/onboarding/assets/placeholder.png b/...-components/public/assets/placeholder.png → ...mplates/onboarding/assets/placeholder.png
diff --git a/...ges/manager-react-components/src/components/templates/onboarding/onboarding.component.tsx b/...ges/manager-react-components/src/components/templates/onboarding/onboarding.component.tsx
@@ -11,12 +11,11 @@ import {
 import { OsdsButton, OsdsIcon, OsdsText } from '@ovhcloud/ods-components/react';
 import React, { PropsWithChildren } from 'react';
 
-import placeholderImg from '../../../../public/assets/placeholder.png';
-
 import {
   ODS_THEME_COLOR_HUE,
   ODS_THEME_COLOR_INTENT,
 } from '@ovhcloud/ods-common-theming';
+import placeholderSrc from './assets/placeholder.png';
 
 type OnboardingLayoutButtonProps = {
   orderButtonLabel?: string;
@@ -110,7 +109,7 @@ export const OnboardingLayout: React.FC<OnboardingLayoutProps> = ({
         <section className="flex flex-col items-center mt-8">
           <img
             className={`max-h-28 ${imgClassName ?? ''}`}
-            src={placeholderImg}
+            src={placeholderSrc}
             {...imgProps}
           />
           <OsdsText

diff --git a/packages/manager-react-components/src/components/templates/onboarding/onboarding.stories.tsx b/packages/manager-react-components/src/components/templates/onboarding/onboarding.stories.tsx
@@ -5,7 +5,7 @@ import {
   OnboardingLayoutProps,
 } from './onboarding.component';
 import { Card } from '../../navigation/card/card.component';
-import placeholderSrc from './../../../../public/assets/placeholder.png';
+import placeholderSrc from './assets/placeholder.png';
 
 export const defaultProps: OnboardingLayoutProps = {
   title: 'Welcome to Onboarding',

diff --git a/packages/manager-react-components/src/index.css b/packages/manager-react-components/src/index.css
diff --git a/packages/manager-react-components/src/index.ts b/packages/manager-react-components/src/index.ts
@@ -1,5 +1,4 @@
 import './tailwind/theme.css';
-import './index.css';
 import '@ovhcloud/ods-theme-blue-jeans/dist/index.css';
 import './enumTypes';
 

diff --git a/packages/manager-react-components/src/lib.ts b/packages/manager-react-components/src/lib.ts
@@ -1,5 +1,4 @@
 export * from './hooks';
-export * from './hooks/feature-availability/useFeatureAvailability';
 export * from './components';
 export * from './enumTypes';
 export * from './utils/click-utils';