fix(procedures): adjustments to gdpr form

ref: MANAGER-15317 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
ovh · Oct 18, 2024 · 79a055e · 79a055e
1 parent 7727faf
commit 79a055e
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 18 deletions.
diff --git a/packages/manager/apps/procedures/src/pages/rgdp/rgdpForm/FileField/FileField.component.tsx b/packages/manager/apps/procedures/src/pages/rgdp/rgdpForm/FileField/FileField.component.tsx
@@ -5,7 +5,6 @@ import {
   ODS_THEME_COLOR_INTENT,
   ODS_THEME_TYPOGRAPHY_LEVEL,
 } from '@ovhcloud/ods-common-theming';
-import { ODS_TEXT_SIZE } from '@ovhcloud/ods-components';
 import {
   FileInputContainer,
   FileWithError,
@@ -69,7 +68,7 @@ export const FileField: FunctionComponent<Props> = ({
                 level={ODS_THEME_TYPOGRAPHY_LEVEL.heading}
                 color={ODS_THEME_COLOR_INTENT.primary}
               >
-                {label}:{required && <sup>*</sup>}
+                {label} :
               </OsdsText>
             </label>
             <FileInputContainer.FileInput />

diff --git a/packages/manager/apps/procedures/src/pages/rgdp/rgdpForm/RGDPForm.component.tsx b/packages/manager/apps/procedures/src/pages/rgdp/rgdpForm/RGDPForm.component.tsx
@@ -192,6 +192,10 @@ export const RGDPForm: FunctionComponent = () => {
           name="requestDescription"
           required={t('rgdp_form_validation_message_required')}
           control={control}
+          pattern={{
+            value: TextInputRegex,
+            message: t('rgdp_form_validation_message_invalid_format'),
+          }}
         />
       </div>
       <div>

diff --git a/packages/manager/apps/procedures/src/pages/rgdp/rgdpForm/RGDPForm.test.tsx b/packages/manager/apps/procedures/src/pages/rgdp/rgdpForm/RGDPForm.test.tsx
@@ -47,24 +47,26 @@ describe('RGDPForm', () => {
     const { getByText } = renderForm();
 
     await waitFor(() => {
-      expect(getByText('rgdp_form_field_label_firstname:')).toBeInTheDocument();
-      expect(getByText('rgdp_form_field_label_surname:')).toBeInTheDocument();
-      expect(getByText('rgdp_form_field_label_email:')).toBeInTheDocument();
       expect(
-        getByText('rgdp_form_field_label_confirm_email:'),
+        getByText('rgdp_form_field_label_firstname :'),
+      ).toBeInTheDocument();
+      expect(getByText('rgdp_form_field_label_surname :')).toBeInTheDocument();
+      expect(getByText('rgdp_form_field_label_email :')).toBeInTheDocument();
+      expect(
+        getByText('rgdp_form_field_label_confirm_email :'),
       ).toBeInTheDocument();
       expect(getByText('rgdp_form_field_label_subject')).toBeInTheDocument();
       expect(
         getByText('rgdp_form_field_label_subject_detail'),
       ).toBeInTheDocument();
       expect(
-        getByText('rgdp_form_field_label_request_description:'),
+        getByText('rgdp_form_field_label_request_description :'),
       ).toBeInTheDocument();
 
-      expect(getByText('rgdp_form_field_label_id_front:')).toBeInTheDocument();
-      expect(getByText('rgdp_form_field_label_id_back:')).toBeInTheDocument();
+      expect(getByText('rgdp_form_field_label_id_front :')).toBeInTheDocument();
+      expect(getByText('rgdp_form_field_label_id_back :')).toBeInTheDocument();
       expect(
-        getByText('rgdp_form_field_label_other_documents:'),
+        getByText('rgdp_form_field_label_other_documents :'),
       ).toBeInTheDocument();
     });
   });

diff --git a/...ges/manager/apps/procedures/src/pages/rgdp/rgdpForm/SelectField/SelectField.component.tsx b/...ges/manager/apps/procedures/src/pages/rgdp/rgdpForm/SelectField/SelectField.component.tsx
@@ -64,7 +64,7 @@ export const SelectField: FunctionComponent<Props> = ({
                   level={ODS_THEME_TYPOGRAPHY_LEVEL.heading}
                   color={ODS_THEME_COLOR_INTENT.primary}
                 >
-                  {label}:
+                  {label} :
                 </OsdsText>
               </label>
             )}

diff --git a/...manager/apps/procedures/src/pages/rgdp/rgdpForm/TextAreaField/TextAreaField.component.tsx b/...manager/apps/procedures/src/pages/rgdp/rgdpForm/TextAreaField/TextAreaField.component.tsx
@@ -54,7 +54,7 @@ export const TextAreaField: FunctionComponent<Props> = ({
                   level={ODS_THEME_TYPOGRAPHY_LEVEL.heading}
                   color={ODS_THEME_COLOR_INTENT.primary}
                 >
-                  {label}:
+                  {label} :
                 </OsdsText>
               </label>
             )}

diff --git a/packages/manager/apps/procedures/src/pages/rgdp/rgdpForm/TextField/TextField.component.tsx b/packages/manager/apps/procedures/src/pages/rgdp/rgdpForm/TextField/TextField.component.tsx
@@ -56,7 +56,7 @@ export const TextField: FunctionComponent<Props> = ({
                   level={ODS_THEME_TYPOGRAPHY_LEVEL.heading}
                   color={ODS_THEME_COLOR_INTENT.primary}
                 >
-                  {label}:
+                  {label} :
                 </OsdsText>
               </label>
             )}

diff --git a/packages/manager/apps/procedures/src/public/translations/rgdp/Messages_fr_FR.json b/packages/manager/apps/procedures/src/public/translations/rgdp/Messages_fr_FR.json
@@ -22,11 +22,12 @@
   "rgdp_form_subject_opposition_right": "Droit d'opposition",
   "rgdp_form_subject_rectification_right": "Droit de rectification",
   "rgdp_form_subject_access_right": "Droit d'accès",
-  "rgdp_form_subject_erasure_right": "Droit à l'effacement",
-  "rgdp_form_subject_limitation_right": "Droit à la limitation du traitement",
-  "rgdp_form_subject_portability_right": "Droit à la portabilité des données",
-  "rgdp_form_subject_payment_method_remove": "Suppression des informations de paiement",
-  "rgdp_form_subject_other_request": "Autre demande",
+
+  "rgdp_form_subject_erasure_right": "Droit d'effacement",
+  "rgdp_form_subject_limitation_right": "Droit à la limitation",
+  "rgdp_form_subject_portability_right": "Droit à la portabilité",
+  "rgdp_form_subject_payment_method_remove": "Supprimer un moyen de paiement",
+  "rgdp_form_subject_other_request": "Autre demande au DPO",
   "rgdp_legal_information": "Les données collectées ci-dessus sont nécessaires au traitement de votre demande. Elles seront conservées pour une durée de 5 ans. Dans l'hypothèse où une copie de votre pièce d'identité viendrait à vous être demandé, celle-ci sera conservée pour une durée maximale de 15 jours.",
   "rgdp_legal_information_policy": "Pour en savoir plus, sur le traitement de vos données personnelles et connaître vos droits, vous pouvez consulter notre <a style='color:#2563eb; font-weight: 700;' href='{{legalPolicyLink}}' target='_blank'>Politique d'utilisation de données à caractère personnel OVHcloud.</a>",
   "rgdp_form_upload_documents_title": "Déposez vos documents",