feat(container): added aggreements modal and reviewed modals display

ref: MANAGER-14722 Signed-off-by: Jacques Larique <[email protected]>
ovh · Nov 12, 2024 · a3479a6 · a3479a6
1 parent 25e78fa
commit a3479a6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/packages/manager/apps/container/src/identity-documents-modal/IdentityDocumentsModal.tsx b/packages/manager/apps/container/src/identity-documents-modal/IdentityDocumentsModal.tsx
@@ -52,6 +52,7 @@ export const IdentityDocumentsModal: FunctionComponent = () => {
     setStorage(true);
     trackingPlugin.trackClick({
       name: `${trackingPrefix}::pop-up::link::kyc::cancel`,
+      type: 'action',
       ...trackingContext,
     });
   };

diff --git a/packages/manager/apps/container/src/payment-modal/PaymentModal.tsx b/packages/manager/apps/container/src/payment-modal/PaymentModal.tsx
@@ -35,8 +35,8 @@ interface IPaymentMethod {
   paymentMethodId: number;
 }
 
-const computeAlert = (paymentMethods: IPaymentMethod[]): string => {
-  const currentCreditCard: IPaymentMethod = paymentMethods?.find(currentPaymentMethod => currentPaymentMethod.paymentType === 'CREDIT_CARD'
+const computeAlert = (paymentMethods: IPaymentMethod[] =[]): string => {
+  const currentCreditCard: IPaymentMethod = paymentMethods.find(currentPaymentMethod => currentPaymentMethod.paymentType === 'CREDIT_CARD'
   && currentPaymentMethod.default);
 
   if (currentCreditCard) {
@@ -83,19 +83,16 @@ const PaymentModal = (): JSX.Element => {
   });
 
   useEffect(() => {
-    if (paymentResponse) {
-      const alert = computeAlert(paymentResponse.data);
+    if (isReadyToRequest && !isLoading) {
+      const alert = computeAlert(paymentResponse?.data);
       if (alert) {
         setAlert(alert);
         setShowPaymentModal(true);
       }
-      else if (isReadyToRequest) {
+      else {
         shell.getPlugin('ux').notifyModalActionDone();
       }
     }
-    else if (isReadyToRequest && !isLoading) {
-      shell.getPlugin('ux').notifyModalActionDone();
-    }
   }, [paymentResponse, isReadyToRequest, isLoading]);
 
   return !showPaymentModal ? (