fix(user management): required "group" field not well validated by fo…

…rm (#9897) In "Add user" form, "group" field was defined by default with an impossible value. So form validator doesn't see issue if field was not filled by customer. But customer was getting a strange error. ref: MANAGER-12070 Signed-off-by: Vincent Cassé <[email protected]>
ovh · Aug 28, 2023 · c90138d · c90138d
1 parent b19864f
commit c90138d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/...ges/manager/apps/dedicated/client/app/account/user/users/add/user-users-add.controller.js b/...ges/manager/apps/dedicated/client/app/account/user/users/add/user-users-add.controller.js
@@ -17,9 +17,7 @@ export default class UserAccountUsersAddCtrl {
     this.alerter = Alerter;
     this.$translate = $translate;
     this.me = coreConfig.getUser();
-    this.user = {
-      group: 'REGULAR',
-    };
+    this.user = {};
     this.groups = [];
     this.loader = true;
     this.PASSWORD_MIN_LENGTH = 8;

diff --git a/packages/manager/apps/dedicated/client/app/account/user/users/add/user-users-add.html b/packages/manager/apps/dedicated/client/app/account/user/users/add/user-users-add.html
@@ -140,7 +140,10 @@
                     </span>
                 </div>
 
-                <div class="form-group">
+                <div
+                    class="form-group"
+                    data-ng-class="{ 'has-error': $ctrl.userAccountUsersAddForm.group.$touched && $ctrl.userAccountUsersAddForm.group.$invalid }"
+                >
                     <label
                         class="control-label"
                         for="group"
@@ -156,6 +159,17 @@
                         data-ng-model="$ctrl.user.group"
                     >
                     </select>
+                    <span
+                        class="help-block"
+                        role="alert"
+                        data-ng-if="$ctrl.userAccountUsersAddForm.group.$touched"
+                        data-ng-messages="$ctrl.userAccountUsersAddForm.group.$touched && $ctrl.userAccountUsersAddForm.group.$error"
+                    >
+                        <span
+                            data-ng-message="required"
+                            data-translate="user_users_add_required"
+                        ></span>
+                    </span>
                 </div>
 
                 <div