Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on Pci-Rancher Onboarding page: image is too big #13389

Closed
2 tasks done
ppprevost opened this issue Oct 2, 2024 · 0 comments · Fixed by #13372
Closed
2 tasks done

Regression on Pci-Rancher Onboarding page: image is too big #13389

ppprevost opened this issue Oct 2, 2024 · 0 comments · Fixed by #13372
Assignees
Labels
bug Something isn't working

Comments

@ppprevost
Copy link
Contributor

Have you already contacted our help centre?

  • Yes, I have contacted the help centre.

Is there an existing issue for this?

  • I have checked the existing issues

Describe the bug

QA team has identified a regression on PCI-Rancher.
Upon investigation, it appears that there was a PR on manager-react-component on onBoarding pages 7 seven days ago.
The recent PR from tibs245 is likely the source if the issue:
https://github.com/ovh/manager/pull/13134/files
It looks like the className has changed, before it was hardcoded in className="max-h-[150px]" and now className={max-h-28 ${imgClassName ?? ''}} but seems to be empty in props
Thank you for your attention

Steps To Reproduce

1 - Go to prod OVH > Public Cloud > Pci-Rancher
Screenshot 2024-10-01 at 10 56 22

Expected Behavior

The size must stay constant on all onBoarding pages

What browsers are you using?

Chrome

Which devices are used?

Desktop

Additional information to add?

No response

@ppprevost ppprevost added the bug Something isn't working label Oct 2, 2024
@tibs245 tibs245 linked a pull request Oct 2, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants