Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-components): fix onboarding default size #13372

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(react-components): fix onboarding default size #13372

merged 1 commit into from
Oct 22, 2024

Conversation

tibs245
Copy link
Contributor

@tibs245 tibs245 commented Oct 1, 2024 •
edited
Loading

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #13389
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

@tibs245 tibs245 requested review from a team as code owners October 1, 2024 11:26
@tibs245 tibs245 self-assigned this Oct 1, 2024
@github-actions github-actions bot added the bug Something isn't working label Oct 1, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tibs245 tibs245 linked an issue Oct 2, 2024 that may be closed by this pull request
Regression on Pci-Rancher Onboarding page: image is too big #13389
Closed
2 tasks
darsene
darsene previously approved these changes Oct 3, 2024
View reviewed changes
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging and removed has conflicts Has conflicts to resolve before merging labels Oct 11, 2024
@tibs245 tibs245 changed the base branch from master to develop October 18, 2024 13:24
@tibs245 tibs245 dismissed darsene’s stale review October 18, 2024 13:24

The base branch was changed.

@anooparveti anooparveti merged commit 6a5d7d2 into develop Oct 22, 2024
16 checks passed
@anooparveti anooparveti deleted the fix/onboarding-size-on-not-configured-theming branch October 22, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darsene darsene darsene approved these changes

@anooparveti anooparveti anooparveti approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

Assignees

@tibs245 tibs245

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression on Pci-Rancher Onboarding page: image is too big
3 participants
@tibs245 @anooparveti @darsene