Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/pci rancher fix value tapc 1615 #13026

Merged
merged 9 commits into from
Oct 10, 2024
Merged

Fix/pci rancher fix value tapc 1615 #13026

merged 9 commits into from
Oct 10, 2024

Conversation

ppprevost
Copy link
Contributor

@ppprevost ppprevost commented Sep 10, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix TAPC-1615
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • [] Breaking change is mentioned in relevant commits

Description

Related

@ppprevost ppprevost requested review from a team as code owners September 10, 2024 12:53
@ppprevost ppprevost changed the base branch from master to feat/rancher-ga-epic September 10, 2024 12:55
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 4, 2024
@ppprevost ppprevost changed the base branch from release/public-cloud-w41 to develop October 4, 2024 08:08
@ppprevost ppprevost dismissed stale reviews from fredericvilcot and frenautvh October 4, 2024 08:08

The base branch was changed.

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 4, 2024
@ppprevost ppprevost force-pushed the fix/pci-rancher_fix-value_tapc-1615 branch from 9c9c1d3 to fd99b2e Compare October 9, 2024 15:59
fredericvilcot
fredericvilcot previously approved these changes Oct 9, 2024
View reviewed changes
ovh-ux-cds and others added 9 commits October 10, 2024 12:04
@ovh-ux-cds
fix(i18n): add missing translations [CDS 3343]
8b9c3ee 
Signed-off-by: CDS Translator Agent <[email protected]>
fix(pci.rancher): fix dash and date
7a3ae3f 
ref: TAPC-1615
Signed-off-by: Pierre-Philippe <[email protected]>
fix(pci.rancher): delete useless translation hook
a176d3d 
ref: TAPC-1615
Signed-off-by: Pierre-Philippe <[email protected]>
fix(pci.rancher): add displaydate dependency
f0d406c 
ref: TAPC-1615
Signed-off-by: Pierre-Philippe <[email protected]>
fix(pci.rancher): more descriptive on date
4d8d3e8 
ref: TAPC-1615
Signed-off-by: Pierre-Philippe <[email protected]>
@ppprevost
fix(pci.rancher): pr review
41d69fa 
ref: TAPC-1615
Signed-off-by: Pierre-Philippe <[email protected]>
fix(pci.rancher): add component and add to list the 0 if no vCPUs
92be18c 
ref: TAPC-1615
Signed-off-by: Pierre-Philippe <[email protected]>
fix(pci.rancher): update ts
844dba0 
ref: TAPC-1615
Signed-off-by: Pierre-Philippe <[email protected]>
fix(pci.rancher): delete useless useref
a4d8cd5 
ref: TAPC-1615
Signed-off-by: Pierre-Philippe <[email protected]>
@ppprevost ppprevost force-pushed the fix/pci-rancher_fix-value_tapc-1615 branch from fd99b2e to b164562 Compare October 10, 2024 10:05
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 10, 2024
@anooparveti anooparveti changed the base branch from develop to release/public-cloud-w42 October 10, 2024 14:37
@ppprevost ppprevost force-pushed the fix/pci-rancher_fix-value_tapc-1615 branch from b164562 to a4d8cd5 Compare October 10, 2024 14:39
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@anooparveti anooparveti merged commit 8a8890b into release/public-cloud-w42 Oct 10, 2024
11 of 13 checks passed
@anooparveti anooparveti deleted the fix/pci-rancher_fix-value_tapc-1615 branch October 10, 2024 14:45
@github-actions github-actions bot added the fix label Oct 10, 2024
@anooparveti anooparveti mentioned this pull request Oct 10, 2024
Merged
10 tasks
sachinrameshn pushed a commit that referenced this pull request Oct 14, 2024
@ppprevost @ovh-ux-cds @sachinrameshn
fix(pci-rancher): fix dash and date (#13026)
18a13e6 
ref: TAPC-1615

Signed-off-by: Pierre-Philippe <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti approved these changes

@fredericvilcot fredericvilcot fredericvilcot left review comments

@Eric-ciccotti Eric-ciccotti Eric-ciccotti left review comments

@frenautvh frenautvh frenautvh left review comments

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique was automatically assigned from ovh/team-manager-dev-angularjs

@SimonChaumet SimonChaumet Awaiting requested review from SimonChaumet

Assignees
No one assigned
Labels
bug Something isn't working fix quality check: ok universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ppprevost @SimonChaumet @anooparveti @frenautvh @Eric-ciccotti @fredericvilcot @ovh-ux-cds