feat(dedicated.vps): use sshKey component #13126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinrameshn
requested review from
MaximeBajeux,
anooparveti and
ghyenne
and removed request for
a team
github-actions
bot
added
universe-bare-metal-cloud
translation required
feature
sachinrameshn
force-pushed
the
feat/MANAGER-13088
branch
from
384e59c
to
4ed5d30
Compare
anooparveti
requested changes
Sep 17, 2024
Comment on lines
117
to
121
| <ssh-key | ||
| data-public-key="$ctrl.template.publicSshKey" | ||
| data-required="false" | ||
| > | ||
| </ssh-key> |
There was a problem hiding this comment.
nitpick: Name of the component is too generic. Add the prefix to differentiate it.
There was a problem hiding this comment.
Its been renamed as sshKeySelector
sachinrameshn
force-pushed
the
feat/MANAGER-13088
branch
2 times, most recently
from
4159d91
to
7c6c709
Compare
sachinrameshn
force-pushed
the
feat/MANAGER-14906
branch
from
312fc60
to
861ebe5
Compare
github-actions
bot
added
the
has conflicts
sachinrameshn
force-pushed
the
feat/MANAGER-13088
branch
from
7c6c709
to
63bc1d0
Compare
github-actions
bot
removed
the
has conflicts
mhelhali-soufien
approved these changes
Sep 23, 2024
ghyenne
approved these changes
Sep 23, 2024
sachinrameshn
force-pushed
the
feat/MANAGER-14906
branch
from
861ebe5
to
147bf8f
Compare
github-actions
bot
added
the
has conflicts
ref: MANAGER-13088 Signed-off-by: Sachin Ramesh <[email protected]>
sachinrameshn
force-pushed
the
feat/MANAGER-13088
branch
from
63bc1d0
to
4168f8d
Compare
github-actions
bot
removed
the
has conflicts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: MANAGER-13088
masterBreaking change is mentioned in relevant commitsDescription
Add < ssh-key / > component
Component must have a dropdown with all the SSH keys stored under /me/sshKey
Component must have a textarea where user can manually fill a SSH key or can select a SSH key that is stored in /me/sshKey
Use < ssh-key /> component in below sections:
VPS OS re-installation for old server
Related