Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/tapc 1731 instance new page v1 #13208

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Feat/tapc 1731 instance new page v1 #13208

merged 5 commits into from
Sep 23, 2024

Conversation

fredericvilcot
Copy link
Contributor

Question Answer
Branch? feat/pci-instances
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #1731
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

This PR:

  • declares the /new route
  • initializes the new CreateInstance component
  • enables links in Create an instance buttons in Instances and Onboarding pages
  • refactors the way pages are nested under instances folder
  • improves Breadcrumb component

Related

@fredericvilcot fredericvilcot requested review from a team as code owners September 23, 2024 08:52
@fredericvilcot fredericvilcot requested review from sidlynx, seven-amid, qpavy, antonymarion and oalkabouss and removed request for a team September 23, 2024 08:52
@fredericvilcot fredericvilcot self-assigned this Sep 23, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@fredericvilcot fredericvilcot merged commit ebee944 into feat/pci-instances Sep 23, 2024
12 of 14 checks passed
@fredericvilcot fredericvilcot deleted the feat/TAPC-1731-instance-new-page-v1 branch September 23, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tsiorifamonjena Tsiorifamonjena Tsiorifamonjena approved these changes

@ppprevost ppprevost ppprevost approved these changes

@SimonChaumet SimonChaumet SimonChaumet approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees

@fredericvilcot fredericvilcot

Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fredericvilcot @SimonChaumet @ppprevost @Tsiorifamonjena