Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kms): change wording in service key headline translations #13223

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

vovh
Copy link
Contributor

@vovh vovh commented Sep 23, 2024

Question Answer
Branch? release/infra-hpc-enable-w42
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #MANAGER-15153
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

In the listing page of keys, remove the word "importez" from the label "Créez, importez et gérez vos clés de chiffrements CMK (Customer Managed Keys). "because the import feature is not yet available.

The new wording is: "Créez et gérez vos clés de chiffrements CMK (Customer Managed Keys)."

Related

  • CMT-16760

@vovh vovh marked this pull request as ready for review September 24, 2024 08:02
@vovh vovh requested a review from a team as a code owner September 24, 2024 08:02
rjamet-ovh
rjamet-ovh previously approved these changes Sep 24, 2024
pauldkn
pauldkn previously approved these changes Sep 25, 2024
chipp972
chipp972 previously approved these changes Sep 25, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Sep 26, 2024
ref: MANAGER-15153

Signed-off-by: Vincent BONMARCHAND <[email protected]>
@vovh vovh dismissed stale reviews from chipp972, pauldkn, and rjamet-ovh via 4044987 October 10, 2024 08:57
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 10, 2024
Copy link

sonarcloud bot commented Oct 10, 2024

@vovh vovh changed the base branch from develop to release/infra-hpc-enabler-w42 October 10, 2024 15:10
@vovh vovh merged commit 302851c into release/infra-hpc-enabler-w42 Oct 10, 2024
18 of 20 checks passed
@vovh vovh deleted the fix/MANAGER-15153 branch October 10, 2024 15:12
@vovh vovh mentioned this pull request Oct 10, 2024
6 tasks
vovh added a commit that referenced this pull request Oct 14, 2024
ref: MANAGER-15153

Signed-off-by: Vincent BONMARCHAND <[email protected]>
Co-Authored-by: CDS Translator Agent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enabler quality check: ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants