Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zimbra): add loading to datagrids #13241

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat(zimbra): add loading to datagrids #13241

merged 1 commit into from
Sep 25, 2024

Conversation

tristanwagner
Copy link
Contributor

Question Answer
Branch? fix/zimbra-beta-improvement
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15389
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

also prevent useless refetchs from overridedpages

Related

@tristanwagner tristanwagner force-pushed the feat/MANAGER-15389 branch 3 times, most recently from 56666e1 to 5be3332 Compare September 24, 2024 15:41
@tristanwagner tristanwagner self-assigned this Sep 24, 2024
@tristanwagner tristanwagner marked this pull request as ready for review September 24, 2024 15:44
@tristanwagner tristanwagner requested review from a team as code owners September 24, 2024 15:44
@tristanwagner tristanwagner requested review from kqesar, frenautvh, tibs245, darsene and JacquesLarique and removed request for a team September 24, 2024 15:44
@tristanwagner tristanwagner force-pushed the feat/MANAGER-15389 branch 2 times, most recently from 9ec7309 to 097baf0 Compare September 25, 2024 07:10
@tristanwagner
feat(zimbra): add loading to datagrids
f61b2fb 
ref: MANAGER-15389
Signed-off-by: Tristan WAGNER <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
16.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@tristanwagner tristanwagner merged commit bda90bb into fix/zimbra-beta-improvement Sep 25, 2024
13 of 14 checks passed
@tristanwagner tristanwagner deleted the feat/MANAGER-15389 branch September 25, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti left review comments

@stif59100 stif59100 stif59100 approved these changes

@ghyenne ghyenne ghyenne approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 was automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene was automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique was automatically assigned from ovh/team-manager-dev-angularjs

Assignees

@tristanwagner tristanwagner

Labels
feature New feature universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tristanwagner @anooparveti @ghyenne @stif59100