Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedicated): filter organizations when order ipv4 block #13464

Merged
merged 3 commits into from
Nov 14, 2024
Merged

feat(dedicated): filter organizations when order ipv4 block #13464

merged 3 commits into from
Nov 14, 2024

Conversation

mhelhali-soufien
Copy link
Contributor

Question Answer
Branch? master
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets Fix #MANAGER-15314
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@mhelhali-soufien mhelhali-soufien requested a review from a team as a code owner October 7, 2024 07:39
sachinrameshn
sachinrameshn reviewed Oct 8, 2024
View reviewed changes
packages/manager/apps/dedicated/client/app/components/ip/agoraOrder/ipv4/ipv4.constant.js Outdated
export const SERVER_REGION = {
USA: 'USA',
CANADA: 'CANADA - ASIA',
EUROP: 'EUROPE',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
EUROP: 'EUROPE',
EUROPE: 'EUROPE',

sachinrameshn
sachinrameshn reviewed Oct 8, 2024
View reviewed changes
packages/manager/apps/dedicated/client/app/components/ip/agoraOrder/ipv4/ipv4.controller.js Outdated
@@ -228,13 +230,13 @@ export default class AgoraIpV4OrderController {
static getRegionFromServiceName(serviceName) {
const serviceExt = last(serviceName.split('.'));
if (['eu', 'net'].includes(serviceExt)) {
return 'EUROPE';
return SERVER_REGION.EUROP;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return SERVER_REGION.EUROP;
return SERVER_REGION.EUROPE;

sachinrameshn
sachinrameshn requested changes Oct 8, 2024
View reviewed changes
packages/manager/apps/dedicated/client/app/components/ip/agoraOrder/ipv4/ipv4.controller.js Outdated
this.organisations = registry
? organisations.filter((org) => org.registry === registry)
: organisations;
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should't have a else case. This change is for all the service not only for dedicated server. We need to retain this for all service type.

qpavy
qpavy previously approved these changes Oct 8, 2024
View reviewed changes
sachinrameshn
sachinrameshn requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@sachinrameshn sachinrameshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to show both the organisation for US region.

qpavy
qpavy previously approved these changes Oct 10, 2024
View reviewed changes
sachinrameshn
sachinrameshn reviewed Oct 11, 2024
View reviewed changes
packages/manager/apps/dedicated/client/app/components/ip/agoraOrder/ipv4/ipv4.controller.js
@@ -372,9 +378,6 @@ export default class AgoraIpV4OrderController {
.then((data) => {
let countries = data;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If at all we have countries coming from API how will we handling the organization filter ?
We are dependent on region from service name if the country is coming as empty. And I see you have removed this logic. Shouldn't we need to keep as is and get the region based on countries ?

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 14, 2024
@mhelhali-soufien mhelhali-soufien force-pushed the feat/MANAGER-15314 branch 2 times, most recently from a921c54 to a6e81d1 Compare October 31, 2024 08:41
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 31, 2024
sachinrameshn
sachinrameshn previously approved these changes Oct 31, 2024
View reviewed changes
qpavy
qpavy previously approved these changes Oct 31, 2024
View reviewed changes
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 5, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 14, 2024
@mhelhali-soufien mhelhali-soufien added quality check: ok has conflicts Has conflicts to resolve before merging labels Nov 14, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 14, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sachinrameshn sachinrameshn changed the base branch from master to release/infra-hpc-w47 November 14, 2024 16:32
@sachinrameshn sachinrameshn merged commit c50f80a into release/infra-hpc-w47 Nov 14, 2024
17 of 18 checks passed
@sachinrameshn sachinrameshn deleted the feat/MANAGER-15314 branch November 14, 2024 16:46
@sachinrameshn sachinrameshn mentioned this pull request Nov 14, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinrameshn sachinrameshn sachinrameshn approved these changes

@qpavy qpavy qpavy approved these changes

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature quality check: ok universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhelhali-soufien @qpavy @sachinrameshn