Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci): add all filters to useProductAvailability #13505

Closed
wants to merge 1 commit into from
Closed

feat(pci): add all filters to useProductAvailability #13505

wants to merge 1 commit into from

Conversation

SimonChaumet
Copy link
Contributor

@SimonChaumet SimonChaumet commented Oct 8, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? yes
Tickets
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Add possibility to use other filters in useProductAvailability

Related

@SimonChaumet
feat(pci): add all filters to useProductAvailability
67f3068 
ref: TAPC-1139

BREAKING CHANGE: parameter of useProductAvailability needs to be an
object of filters instead of product

Signed-off-by: Simon Chaumet <[email protected]>
@SimonChaumet SimonChaumet requested review from a team as code owners October 8, 2024 15:52
@github-actions github-actions bot added the feature New feature label Oct 8, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SimonChaumet
Copy link
Contributor Author

@anooparveti can you merge it ?

@SimonChaumet SimonChaumet mentioned this pull request Oct 11, 2024
Merged
8 tasks
@SimonChaumet
Copy link
Contributor Author

Resolved in #13489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@selm3n selm3n selm3n approved these changes

@frenautvh frenautvh frenautvh approved these changes

@lionel95200x lionel95200x lionel95200x approved these changes

@ppprevost ppprevost ppprevost approved these changes

@acavalloni acavalloni acavalloni approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SimonChaumet @acavalloni @ppprevost @lionel95200x @frenautvh @selm3n @fredericvilcot