Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hycu): create order page #13560

Merged
merged 2 commits into from
Oct 23, 2024
Merged

feat(hycu): create order page #13560

merged 2 commits into from
Oct 23, 2024

Conversation

ThibaudCrespin
Copy link
Contributor

@ThibaudCrespin ThibaudCrespin commented Oct 11, 2024 •
edited
Loading

ref: MANAGER-14504

Question Answer
Branch? feat/hycu
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-14504
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Create order page for HYCU license products

Related

@ThibaudCrespin ThibaudCrespin marked this pull request as ready for review October 14, 2024 07:33
@ThibaudCrespin ThibaudCrespin requested review from a team as code owners October 14, 2024 07:33
@ThibaudCrespin ThibaudCrespin requested review from kqesar, frenautvh, tibs245, MaximeBajeux and mhelhali-soufien and removed request for a team October 14, 2024 07:33
@tibs245 tibs245 force-pushed the feat/hycu branch 2 times, most recently from f2faa42 to 56a3eaa Compare October 21, 2024 09:33
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed has conflicts Has conflicts to resolve before merging labels Oct 22, 2024
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Oct 22, 2024
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging universe-bare-metal-cloud dependencies Pull requests that update a dependency file universe-hosted-private-cloud container labels Oct 22, 2024
feat(hycu): create order page
98c85f4 
  ref: MANAGER-14504

Signed-off-by: Thibaud Crespin <[email protected]>
@github-actions github-actions bot removed universe-bare-metal-cloud dependencies Pull requests that update a dependency file universe-hosted-private-cloud container has conflicts Has conflicts to resolve before merging labels Oct 22, 2024
fix(hycu): build errors with tests and sonar
b6ac9d2 
  ref: MANAGER-14504

Signed-off-by: Thibaud Crespin <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ThibaudCrespin ThibaudCrespin merged commit 88143a7 into feat/hycu Oct 23, 2024
10 of 12 checks passed
@ThibaudCrespin ThibaudCrespin deleted the feat/MANAGER-14504 branch October 23, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipp972 chipp972 chipp972 approved these changes

@tibs245 tibs245 tibs245 approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@rjamet-ovh rjamet-ovh Awaiting requested review from rjamet-ovh

Assignees
No one assigned
Labels
common feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThibaudCrespin @tibs245 @chipp972 @rjamet-ovh