Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(procedures): gdpr implementation of document upload #13581

Merged
merged 1 commit into from
Oct 18, 2024
Merged

feat(procedures): gdpr implementation of document upload #13581

merged 1 commit into from
Oct 18, 2024

Conversation

oalkabouss
Copy link
Contributor

@oalkabouss oalkabouss commented Oct 14, 2024 •
edited
Loading

ref: MANAGER-15339

Question Answer
Branch? feat/MANAGER-15317
Bug fix? no
New feature? yes
Breaking change? yes/no
Tickets MANAGER-15339
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@oalkabouss oalkabouss requested review from a team as code owners October 14, 2024 09:25
@oalkabouss oalkabouss requested review from frenautvh, seven-amid, tibs245, anooparveti and darsene and removed request for a team October 14, 2024 09:25
JacquesLarique
JacquesLarique reviewed Oct 14, 2024
View reviewed changes
packages/manager/apps/procedures/src/pages/rgdp/rgdpForm/FileField/FileField.component.tsx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't it possible to reuse the FormDocumentFieldList component ?

packages/manager/apps/procedures/src/components/FileInput/FileInputList.tsx Outdated
Comment on lines 30 to 42
<OsdsText>
<span className="text-sky-900 text-xs font-semibold">
{t('account-disable-2fa-file-input-attachments')}
</span>
</OsdsText>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need the span inside the ODS text ?
Also, is there any impact on 2FA pages display ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i took the opportunity to add this text in the ods components, it has no impact on the display, as I compared the two

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why do we need a span inside the ODS text ? wouldn't the text component be enough ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because i wanted it to look as close as possible to the previous one

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 14, 2024
@oalkabouss oalkabouss force-pushed the feat/MANAGER-15339 branch 2 times, most recently from bb0ddf9 to 73ca3de Compare October 15, 2024 08:29
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 15, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 16, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 17, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 17, 2024
Base automatically changed from feat/MANAGER-15317 to feat/procedures-gdpr October 17, 2024 08:34
feat(procedures): gdpr implementation of document upload
3ff250e 
ref: MANAGER-15339

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 17, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@oalkabouss oalkabouss merged commit 94d9618 into feat/procedures-gdpr Oct 18, 2024
12 of 14 checks passed
@oalkabouss oalkabouss deleted the feat/MANAGER-15339 branch October 18, 2024 05:26
oalkabouss added a commit that referenced this pull request Oct 28, 2024
@oalkabouss
feat(procedures): gdpr implementation of document upload (#13581)
899e79d 
ref: MANAGER-15339

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@MaximeBajeux MaximeBajeux MaximeBajeux approved these changes

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oalkabouss @MaximeBajeux @JacquesLarique