feat(hpc-vmware-managed-vcd): add integration tests #13592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipp972
requested review from
kqesar,
frenautvh,
tibs245,
darsene and
mhelhali-soufien
and removed request for
a team
pauldkn
approved these changes
Oct 15, 2024
chipp972
force-pushed
the
feat/vcd-15566
branch
from
5caaef8
to
fb5f369
Compare
ref: MANAGER-15566 Signed-off-by: Nicolas Pierre-charles <[email protected]>
chipp972
force-pushed
the
feat/vcd-15566
branch
from
fb5f369
to
1aafac2
Compare
|
rjamet-ovh
reviewed
Oct 16, 2024
| }: GetOrganizationMocksParams): Handler[] => { | ||
| const nb = allOrgsBackedUp ? 1 : nbOrganization; | ||
| return [ | ||
| { | ||
| url: '/vmwareCloudDirector/organization/:id/virtualDataCenter', |
There was a problem hiding this comment.
you can't use some route constants here?
There was a problem hiding this comment.
I will fix them in next TU PR
rjamet-ovh
approved these changes
Oct 16, 2024
darsene
pushed a commit
that referenced
this pull request
Oct 17, 2024
ref: MANAGER-15566 Signed-off-by: Nicolas Pierre-charles <[email protected]>
darsene
pushed a commit
that referenced
this pull request
Oct 18, 2024
ref: MANAGER-15566 Signed-off-by: Nicolas Pierre-charles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: MANAGER-15566
developOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
Related