Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(account): handle demo feedback carte aadhaar rules #13615

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

MaximeBajeux
Copy link
Contributor

Question Answer
Branch? feat/kyc-digital-process
Bug fix? yes
New feature? yes
Breaking change? no
Tickets MANAGER-15555
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

Maxime Bajeux added 3 commits October 11, 2024 15:41
ref: MANAGER-15555

Signed-off-by: Maxime Bajeux <[email protected]>
ref: MANAGER-15555

Signed-off-by: Maxime Bajeux <[email protected]>
@MaximeBajeux MaximeBajeux requested a review from a team as a code owner October 16, 2024 08:06
@MaximeBajeux MaximeBajeux requested review from tibs245, anooparveti and mhelhali-soufien and removed request for a team October 16, 2024 08:06
@MaximeBajeux MaximeBajeux requested review from a team as code owners October 16, 2024 08:20
@MaximeBajeux MaximeBajeux requested review from sidlynx and kqesar and removed request for a team October 16, 2024 08:20
Copy link

sonarcloud bot commented Oct 18, 2024

"identity_documents_modal_button_start": "Start",
"identity_documents_modal_button_later": "Skip",
"identity_documents_modal_more_info": "More information",
"identity_documents_modal_legal_information": "OVHcloud is obligated to perform Know Your Customer (KYC) checks on all its customers, pursuant to local regulations in force: Directions No. 20(3)/2022-CERT-In. __ <br>OVHcloud follows a process to collect supporting documents in order to verify the identity and address of its customers. OVHcloud cannot provide you with its services if you don’t submit the required documents."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I missed it originally (so this comment is not blocking) but we should avoid (as much as possible) to use html in our translation.
So this should have been split in two separated translations

@MaximeBajeux MaximeBajeux merged commit 8f59f9c into feat/kyc-digital-process Oct 21, 2024
13 checks passed
@MaximeBajeux MaximeBajeux deleted the fix/MANAGER-15555 branch October 21, 2024 11:19
MaximeBajeux added a commit that referenced this pull request Oct 21, 2024
ref: MANAGER-15555
Signed-off-by: Maxime Bajeux <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants