Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kms): add clear notifications before trigger new notif #13629

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix(kms): add clear notifications before trigger new notif #13629

merged 1 commit into from
Oct 25, 2024

Conversation

vovh
Copy link
Contributor

@vovh vovh commented Oct 16, 2024 •
edited
Loading

ref: MANAGER-15377

Question Answer
Branch? fix/key-management-service-lean
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #MANAGER-15377
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

After the creation of a credential, the success banners or error banners are still displayed on the page.

Related

@github-actions github-actions bot added enabler bug Something isn't working labels Oct 16, 2024
@vovh vovh marked this pull request as ready for review October 16, 2024 15:06
@vovh vovh requested review from a team as code owners October 16, 2024 15:06
@vovh vovh requested review from sidlynx, frenautvh, qpavy, ghyenne and sachinrameshn and removed request for a team October 16, 2024 15:06
anooparveti
anooparveti previously approved these changes Oct 17, 2024
View reviewed changes
rjamet-ovh
rjamet-ovh previously approved these changes Oct 17, 2024
View reviewed changes
@vovh vovh force-pushed the fix/key-management-service-lean branch from f3d4851 to 74cc7c1 Compare October 17, 2024 13:00
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 17, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 18, 2024
@rjamet-ovh rjamet-ovh force-pushed the fix/key-management-service-lean branch from 7e9fed4 to 438f109 Compare October 23, 2024 14:59
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 23, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 24, 2024
Base automatically changed from fix/key-management-service-lean to develop October 25, 2024 09:43
@chipp972 chipp972 dismissed stale reviews from rjamet-ovh and anooparveti October 25, 2024 09:43

The base branch was changed.

@vovh
fix(kms): add clear notifications before trigger new notif
4b381f1 
ref: MANAGER-15377

Signed-off-by: Vincent BONMARCHAND <[email protected]>
@rjamet-ovh rjamet-ovh changed the base branch from develop to release/enabler-w44 October 25, 2024 15:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@chipp972 chipp972 mentioned this pull request Oct 25, 2024
Merged
3 tasks
@chipp972 chipp972 merged commit bdc98b3 into release/enabler-w44 Oct 25, 2024
14 of 16 checks passed
@chipp972 chipp972 deleted the fix/MANAGER-15377 branch October 25, 2024 15:56
chipp972 pushed a commit that referenced this pull request Oct 29, 2024
@vovh @chipp972
fix(kms): add clear notifications before trigger new notif (#13629)
57be199 
ref: MANAGER-15377

Signed-off-by: Vincent BONMARCHAND <[email protected]>
selm3n pushed a commit that referenced this pull request Oct 31, 2024
@vovh
fix(kms): add clear notifications before trigger new notif (#13629)
33b250b 
ref: MANAGER-15377

Signed-off-by: Vincent BONMARCHAND <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjamet-ovh rjamet-ovh rjamet-ovh approved these changes

@chipp972 chipp972 chipp972 approved these changes

@anooparveti anooparveti anooparveti left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working enabler quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vovh @chipp972 @anooparveti @rjamet-ovh @jmalnuit