Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-load-balancer): add create member modal #13632

Merged
merged 1 commit into from
Oct 18, 2024
Merged

feat(pci-load-balancer): add create member modal #13632

merged 1 commit into from
Oct 18, 2024

Conversation

kqesar
Copy link
Contributor

@kqesar kqesar commented Oct 17, 2024

ref: DTCORE-2660

Question Answer
Branch? feat/pci-load-balancer
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets DTCORE-266à
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@kqesar kqesar requested review from a team as code owners October 17, 2024 07:08
@kqesar kqesar requested review from sidlynx, frenautvh, tibs245, MaximeBajeux and darsene and removed request for a team October 17, 2024 07:08
@kqesar kqesar requested a review from frenautvh October 17, 2024 08:35
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 17, 2024
@kqesar
feat(pci-load-balancer): add create member modal
27a642f 
ref: DTCORE-2660
Signed-off-by: Yoann Fievez <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 17, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@kqesar kqesar merged commit e0b8d27 into feat/DTCORE-2661 Oct 18, 2024
12 of 14 checks passed
@kqesar kqesar deleted the feat/DTCORE-2660 branch October 18, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghyenne ghyenne ghyenne approved these changes

@frenautvh frenautvh frenautvh approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 was automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene was automatically assigned from ovh/team-manager-dev-angularjs

@seven-amid seven-amid Awaiting requested review from seven-amid

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kqesar @frenautvh @seven-amid @ghyenne