feat(hpc-vmware-managed-vcd): add pcc-migration condition #13635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipp972
requested review from
antonymarion,
ghyenne and
sachinrameshn
and removed request for
a team
github-actions
bot
added
universe-bare-metal-cloud
universe-hosted-private-cloud
feature
darsene
requested changes
Oct 17, 2024
packages/manager/apps/dedicated/client/app/dedicatedCloud/details/dedicatedCloud.routing.js
Outdated
Show resolved
Hide resolved
...ages/manager/apps/dedicated/client/app/managedBaremetal/details/managed-baremetal.routing.js
Outdated
Show resolved
Hide resolved
chipp972
force-pushed
the
feat/vcd-15398
branch
from
d678ce2
to
45e336f
Compare
pauldkn
reviewed
Oct 17, 2024
| @@ -95,9 +95,11 @@ export default /* @ngInject */ ($stateProvider) => { | |||
|
|
|||
| managedVCDAvailability: /* @ngInject */ (ovhFeatureFlipping) => | |||
| ovhFeatureFlipping | |||
| .checkFeatureAvailability('hpc-vmware-managed-vcd') | |||
| .checkFeatureAvailability(['hpc-vmware-managed-vcd:pcc-migration']) | |||
There was a problem hiding this comment.
Are brackets [ ] still needed ?
ref: MANAGER-15398 Signed-off-by: Nicolas Pierre-charles <[email protected]>
chipp972
force-pushed
the
feat/vcd-15398
branch
from
45e336f
to
20cd737
Compare
pauldkn
approved these changes
Oct 17, 2024
|
darsene
approved these changes
Oct 17, 2024
darsene
pushed a commit
that referenced
this pull request
Oct 17, 2024
ref: MANAGER-15398 Signed-off-by: Nicolas Pierre-charles <[email protected]>
darsene
pushed a commit
that referenced
this pull request
Oct 18, 2024
ref: MANAGER-15398 Signed-off-by: Nicolas Pierre-charles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: MANAGER-15398
developOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
Related