Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(procedures): implement gdpr document upload and confirmation #13654

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

oalkabouss
Copy link
Contributor

@oalkabouss oalkabouss commented Oct 17, 2024

ref: MANAGER-15368

Question Answer
Branch? feat/MANAGER-15339
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15368
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@oalkabouss oalkabouss requested review from a team as code owners October 17, 2024 16:18
@oalkabouss oalkabouss requested review from sidlynx, kqesar, antonymarion, darsene and mhelhali-soufien and removed request for a team October 17, 2024 16:18
Base automatically changed from feat/MANAGER-15339 to feat/procedures-gdpr October 18, 2024 05:26
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 18, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 18, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test on the display of modals please

FormValue,
} from '@/data/api/rgdp/rgdpApi';

export const useRGDPUploadLinks = ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the doc from SIA, the form data will be sent in this call, so you need to update these two functions

headers: any;
};

export type FormValue = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: MANAGER-15368

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
Copy link

sonarcloud bot commented Oct 21, 2024

@oalkabouss oalkabouss merged commit f2554dc into feat/procedures-gdpr Oct 21, 2024
13 of 14 checks passed
@oalkabouss oalkabouss deleted the feat/MANAGER-15368 branch October 21, 2024 12:14
oalkabouss added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants