Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/navigation get url #13656

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Feat/navigation get url #13656

wants to merge 1 commit into from

Conversation

tibs245
Copy link
Contributor

@tibs245 tibs245 commented Oct 17, 2024

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Feat #13649
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

See issue to understand the needs

@github-actions github-actions bot added the feature New feature label Oct 17, 2024
@tibs245 tibs245 changed the base branch from master to develop October 17, 2024 19:38
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@@ -0,0 +1,45 @@
// eslint-disable-next-line prettier/prettier
import type { ParamValueType } from '@ovh-ux/url-builder';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove this line since the package is not in the right format

@tibs245 tibs245 linked an issue Oct 19, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think react-shell-client will be the right place to add this hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[manager-components]: Add hook for navigation getUrl
3 participants