Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pci-rancher): add Egress Gateway IP #13662

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

Eric-ciccotti
Copy link
Contributor

@Eric-ciccotti Eric-ciccotti commented Oct 18, 2024

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #TAPC-1507
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

This feature adds an Egress Gateway IP field in Rancher.

@Eric-ciccotti Eric-ciccotti force-pushed the feat/TAPC-1507 branch 2 times, most recently from b421135 to c42ad39 Compare October 23, 2024 08:36
ref: TAPC-1507
Signed-off-by: Eric Ciccotti <[email protected]>
Copy link

sonarcloud bot commented Nov 7, 2024

@lionel95200x lionel95200x changed the base branch from develop to release/public-cloud-w46 November 7, 2024 16:28
@lionel95200x lionel95200x merged commit 32bb1cf into release/public-cloud-w46 Nov 7, 2024
17 of 27 checks passed
@lionel95200x lionel95200x deleted the feat/TAPC-1507 branch November 7, 2024 16:37
lionel95200x pushed a commit that referenced this pull request Nov 12, 2024
ref: TAPC-1507

Signed-off-by: Eric Ciccotti <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
anooparveti pushed a commit that referenced this pull request Nov 12, 2024
ref: TAPC-1507

Signed-off-by: Eric Ciccotti <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
ppprevost pushed a commit that referenced this pull request Nov 15, 2024
ref: TAPC-1507

Signed-off-by: Eric Ciccotti <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants