Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(container): fix onboarding last step pop-up overflow #13671

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix(container): fix onboarding last step pop-up overflow #13671

merged 1 commit into from
Oct 18, 2024

Conversation

oalkabouss
Copy link
Contributor

ref: MANAGER-15724

Question Answer
Branch? release/gcj-w43
Bug fix? yes
New feature? no
Breaking change? no
Tickets MANAGER-15724
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

fix(container): fix onboarding last step pop-up overflow
258b22f 
ref: MANAGER-15724

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss oalkabouss requested review from a team as code owners October 18, 2024 13:34
@oalkabouss oalkabouss requested review from sidlynx and frenautvh and removed request for a team October 18, 2024 13:34
@github-actions github-actions bot added container bug Something isn't working labels Oct 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@oalkabouss oalkabouss merged commit 4a6e22e into release/gcj-w43 Oct 18, 2024
14 checks passed
@oalkabouss oalkabouss deleted the fix/MANAGER-15724 branch October 18, 2024 14:03
MaximeBajeux pushed a commit that referenced this pull request Oct 21, 2024
@oalkabouss @MaximeBajeux
fix(container): fix onboarding last step pop-up overflow (#13671)
2343d35 
ref: MANAGER-15724

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@MaximeBajeux MaximeBajeux MaximeBajeux approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
bug Something isn't working container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oalkabouss @MaximeBajeux @JacquesLarique