Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue on Databases Namespace creation / edition #13673

Closed
wants to merge 9 commits into from
Closed

Fixing issue on Databases Namespace creation / edition #13673

wants to merge 9 commits into from

Conversation

abullet33
Copy link
Contributor

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #DATATR-1555
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Fixing issue in edition / creation namespace form

Related

jperchoc and others added 9 commits October 17, 2024 17:37
@jperchoc @abullet33
fix: use localisation to correctly format prices
37dae95 
ref: DATATR-1481
Signed-off-by: Jonathan Perchoc <[email protected]>
@jperchoc @abullet33
feat: add missing region translations for US
2ebe520 
ref: DATATR-1481
Signed-off-by: Jonathan Perchoc <[email protected]>
@jperchoc @abullet33
fix: invalidate services list query on update
3ea12ba 
ref: DATATR-1497
Signed-off-by: Jonathan Perchoc <[email protected]>
@jperchoc @abullet33
fix: translate the unit provided by the api for the metrics (#13341)
133a3cd 
ref: DATATR-1517

Signed-off-by: Jonathan Perchoc <[email protected]>
@abullet33
Fix/databases restore pop up not working well (#13506)
8eeba07 
* fix(pci-databases-analytics): dashboard rework
ref:datatr-1479, datatr-1506

* fix(pci-databases-analytics): restore pop-up fixes
ref:datatr-1439

* fix(pci-databases-analytics): add terminate button for service deletion
ref:datatr-1450

* fix(pci-databases-analytics): display number of services result
ref:datatr-1484

Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
fix(pci-databases-analytics): remove name regex in database form
056cc64 
ref:datatr-1539
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
feat(pci-databases-analytics): fix pr comments
98c4f26 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
fix(pci-databases-analytics): merge translation file
3aea5b6 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
fix(pci.databases): fixing namespaces edition and creation form
70828b8 
ref:DATATR-1556
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33 abullet33 requested review from a team as code owners October 18, 2024 14:14
@github-actions github-actions bot added translation required bug Something isn't working labels Oct 18, 2024
@abullet33 abullet33 closed this Oct 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abullet33 @jperchoc