feat(dedicated.vrack): add occ as new eligibility service in vrack #13678
+123
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
universe-bare-metal-cloud
translation required
common
feature
qpavy
previously approved these changes
Oct 21, 2024
tibs245
reviewed
Oct 21, 2024
| const formattedService = { | ||
| ...service, | ||
| id: service.uuid, | ||
| niceName: service.uuid, |
There was a problem hiding this comment.
Suggested change
| niceName: service.uuid, | |
| displayName: service.uuid, |
I'll let you judge the relevance of the suggestion ;)
There was a problem hiding this comment.
I need to check on this.
tibs245
reviewed
Oct 21, 2024
mhelhali-soufien
previously approved these changes
Oct 21, 2024
sachinrameshn
dismissed stale reviews from mhelhali-soufien and qpavy
via
b9dddd3
sachinrameshn
force-pushed
the
feat/MANAGER-15301
branch
from
3f53aca
to
b9dddd3
Compare
github-actions
bot
added
universe-web-cloud
universe-telecom
dependencies
sachinrameshn
force-pushed
the
feat/MANAGER-15301
branch
from
b9dddd3
to
1da8338
Compare
github-actions
bot
removed
universe-web-cloud
universe-telecom
dependencies
sachinrameshn
added
feature
ref: MANAGER-15301 Signed-off-by: Sachin Ramesh <[email protected]>
sachinrameshn
force-pushed
the
feat/MANAGER-15301
branch
from
1da8338
to
927aff0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterBreaking change is mentioned in relevant commitsDescription
Add OVH Cloud connect as new eligibility service in vrack section.
Related