Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ips): init ips react app #13742

Open
wants to merge 1 commit into
base: project/ip-revamp
Choose a base branch
from
Open

feat(ips): init ips react app #13742

wants to merge 1 commit into from

Conversation

qpavy
Copy link
Contributor

@qpavy qpavy commented Oct 23, 2024

Question Answer
Branch? project/ip-revamp
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-15657
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • [ ] Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • [ ] Breaking change is mentioned in relevant commits

Description

Related

@qpavy qpavy requested review from a team as code owners October 23, 2024 11:23
@qpavy qpavy requested review from frenautvh, seven-amid, tibs245, anooparveti and JacquesLarique and removed request for a team October 23, 2024 11:23
darsene
darsene reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@darsene darsene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix e2e tests, they should work by default once app is generated

@qpavy qpavy requested a review from darsene October 25, 2024 12:19
darsene
darsene previously approved these changes Oct 25, 2024
View reviewed changes
anooparveti
anooparveti requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need to remove e2e configs from generator, it's redundant. Can you remove it manually?

anooparveti
anooparveti reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@anooparveti anooparveti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If mocks folder and cucumber.js is not used, can you remove it?

@qpavy qpavy force-pushed the feat/MANAGER-15657 branch 2 times, most recently from 287eb9a to 2d28f9f Compare November 15, 2024 12:48
@qpavy qpavy changed the base branch from project/ip-revamp to develop November 15, 2024 13:04
@qpavy qpavy dismissed stale reviews from mhelhali-soufien and darsene November 15, 2024 13:04

The base branch was changed.

@qpavy qpavy changed the base branch from develop to project/ip-revamp November 15, 2024 13:04
@qpavy qpavy changed the base branch from project/ip-revamp to develop November 15, 2024 14:52
@qpavy qpavy changed the base branch from develop to project/ip-revamp November 15, 2024 14:53
feat(ips): init ips react app
63e7557 
ref: MANAGER-15657

Signed-off-by: Quentin Pavy <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
34.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhelhali-soufien mhelhali-soufien mhelhali-soufien left review comments

@darsene darsene darsene left review comments

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qpavy @anooparveti @darsene @mhelhali-soufien