Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zimbra): add account order cta & page #13863

Open
wants to merge 1 commit into
base: feat/MANAGER-15840
Choose a base branch
from
Open

feat(zimbra): add account order cta & page #13863

wants to merge 1 commit into from

Conversation

tristanwagner
Copy link
Contributor

@tristanwagner tristanwagner commented Oct 30, 2024 •
edited
Loading

ref: MANAGER-13960

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-13960
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

Needs to be merged after #14011

@tristanwagner tristanwagner self-assigned this Oct 30, 2024
@tristanwagner tristanwagner force-pushed the feat/MANAGER-13960 branch 3 times, most recently from 7ca87bb to e3fcc86 Compare November 4, 2024 12:37
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 4, 2024
@tristanwagner tristanwagner force-pushed the feat/MANAGER-13960 branch 8 times, most recently from 0aefffa to 3a849fd Compare November 6, 2024 12:46
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 6, 2024
@tristanwagner tristanwagner marked this pull request as ready for review November 6, 2024 12:55
@tristanwagner tristanwagner requested review from a team as code owners November 6, 2024 12:55
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging labels Nov 6, 2024
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging and removed has conflicts Has conflicts to resolve before merging labels Nov 8, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 13, 2024
@tristanwagner tristanwagner force-pushed the feat/MANAGER-13960 branch 3 times, most recently from 90793d7 to bfaea93 Compare November 13, 2024 08:50
@tristanwagner tristanwagner changed the base branch from master to fix/MANAGER-16025 November 13, 2024 10:16
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 13, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 13, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 13, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 13, 2024
Base automatically changed from fix/MANAGER-16025 to release/hosting-collaboration-w47 November 14, 2024 17:13
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 14, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 15, 2024
@tristanwagner tristanwagner changed the base branch from release/hosting-collaboration-w47 to feat/MANAGER-15840 November 15, 2024 11:15
@tristanwagner
feat(zimbra): add account express order cta & page
18b14cf 
note that the handling of form field validation is also modified to make it more
convenient to test validity of field

ref: MANAGER-13960

Signed-off-by: Tristan WAGNER <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
34.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stif59100 stif59100 stif59100 left review comments

@antonymarion antonymarion antonymarion left review comments

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees

@tristanwagner tristanwagner

Labels
feature New feature quality check: ok translation required universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tristanwagner @antonymarion @stif59100