Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-private-network): apply design reviews #13921

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(pci-private-network): apply design reviews #13921

wants to merge 1 commit into from

Conversation

kqesar
Copy link
Contributor

@kqesar kqesar commented Nov 4, 2024

ref: DTCORE-2707

Question Answer
Branch? master
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets DTCORE-2707
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@kqesar kqesar requested review from a team as code owners November 4, 2024 14:16
sidlynx
sidlynx previously approved these changes Nov 4, 2024
View reviewed changes
@kqesar kqesar requested a review from sidlynx November 4, 2024 14:41
seven-amid
seven-amid previously approved these changes Nov 4, 2024
View reviewed changes
anooparveti
anooparveti previously approved these changes Nov 5, 2024
View reviewed changes
@kqesar
feat(pci-private-network): apply design reviews
5962cdd 
ref: DTCORE-2707
Signed-off-by: Yoann Fievez <[email protected]>
@kqesar kqesar dismissed stale reviews from anooparveti and seven-amid via 5962cdd November 15, 2024 14:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seven-amid seven-amid seven-amid left review comments

@anooparveti anooparveti anooparveti left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kqesar @sidlynx @anooparveti @seven-amid