feat(container): added an invitation modal to accept contract #14041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 8, 2024 17:36
ref: MANAGER-15988 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-14722 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-14722 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-14722 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-14722 Signed-off-by: Jacques Larique <[email protected]>
JacquesLarique
requested review from
kqesar,
frenautvh,
antonymarion,
MaximeBajeux and
sachinrameshn
github-actions
bot
added
universe-bare-metal-cloud
translation required
container
common
feature
There was a problem hiding this comment.
Should we not do a separated PR for the common changes ?
There was a problem hiding this comment.
They will disappear once their dedicated PR will be merged (#14025)
MaximeBajeux
previously approved these changes
Nov 13, 2024
oalkabouss
reviewed
Nov 13, 2024
| const { data } = await fetchIcebergV2<IamResource>({ | ||
| route: '/iam/resource?resourceType=account', | ||
| }); | ||
| /* |
There was a problem hiding this comment.
Add a note to say why it s commented
| const { t } = useTranslation('agreements-update-modal'); | ||
| const { data: urn } = useAccountUrn({ enabled: region !== 'US' && current === ModalTypes.agreements && window.location.href !== myContractsLink }); | ||
| const { isAuthorized: canUserAcceptAgreements } = useAuthorizationIam(['account:apiovh:me/agreements/accept'], urn); | ||
| const { data: agreements, isLoading } = useAgreementsUpdate({ enabled: canUserAcceptAgreements }); |
| @@ -22,6 +25,7 @@ export default function Container(): JSX.Element { | |||
| chatbotReduced, | |||
| setChatbotReduced, | |||
| } = useContainer(); | |||
| useModals(); | |||
There was a problem hiding this comment.
i guess it is on oversight ?
ref: MANAGER-14722 Signed-off-by: Jacques Larique <[email protected]>
oalkabouss
previously approved these changes
Nov 13, 2024
MaximeBajeux
previously approved these changes
Nov 13, 2024
ref: MANAGER-14722 Signed-off-by: Jacques Larique <[email protected]>
JacquesLarique
dismissed stale reviews from MaximeBajeux and oalkabouss
via
bd620ea
added 2 commits
November 15, 2024 11:37
ref: MANAGER-14722 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-14722 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-14722 Signed-off-by: Jacques Larique <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterBreaking change is mentioned in relevant commits(n/a)Description
Reworked modal display in order to avoid the possibility of having multiple modals displayed at the same time
Set up a new modal to invite customer to accept new / updated contracts
Fix a small tracking issue on KYC India modal
Related