Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): add guide link for eligibility #14074

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat(web): add guide link for eligibility #14074

merged 1 commit into from
Nov 15, 2024

Conversation

antonymarion
Copy link
Contributor

@antonymarion antonymarion commented Nov 13, 2024 •
edited
Loading

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets Feat#MANAGER-15875
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
    - [ ] Breaking change is mentioned in relevant commits

Description

Related

@antonymarion antonymarion requested a review from a team as a code owner November 13, 2024 14:47
@antonymarion antonymarion changed the title Feat/manager 15875 feat(web): add guide link for eligibility Nov 13, 2024
tristanwagner
tristanwagner previously approved these changes Nov 14, 2024
View reviewed changes
@antonymarion antonymarion changed the base branch from master to feat/eligibility November 14, 2024 14:31
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 14, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 14, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 14, 2024
@github-actions github-actions bot removed has conflicts Has conflicts to resolve before merging labels Nov 14, 2024
@antonymarion antonymarion force-pushed the feat/MANAGER-15875 branch 2 times, most recently from 5d20762 to fb72366 Compare November 15, 2024 08:45
feat(web): add guide link for eligibility
23fb1c9 
ref: MANAGER-15875

Signed-off-by: Antony MARION <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@antonymarion antonymarion merged commit d58fa8b into feat/eligibility Nov 15, 2024
13 checks passed
@antonymarion antonymarion deleted the feat/MANAGER-15875 branch November 15, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghyenne ghyenne ghyenne approved these changes

@tristanwagner tristanwagner tristanwagner approved these changes

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonymarion @tristanwagner @ghyenne