feat(manager-react-components): Bump ods version 18.3.0 #14080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboungnaseng-ovhcloud
requested review from
tibs245,
darsene and
JacquesLarique
github-actions
bot
added
documentation
anooparveti
requested changes
Nov 14, 2024
aboungnaseng-ovhcloud
force-pushed
the
feat/mrc-ods-version-18-3
branch
2 times, most recently
from
3a2d6e8
to
d716b2b
Compare
aboungnaseng-ovhcloud
force-pushed
the
feat/mrc-ods-version-18-3
branch
from
cad5081
to
9e4e0e9
Compare
aboungnaseng-ovhcloud
force-pushed
the
feat/mrc-ods-version-18-3
branch
2 times, most recently
from
1b189c5
to
775cb39
Compare
anooparveti
previously approved these changes
Nov 14, 2024
chipp972
previously approved these changes
Nov 14, 2024
aboungnaseng-ovhcloud
force-pushed
the
feat/mrc-ods-version-18-3
branch
from
eb232f9
to
d1fb8c2
Compare
tristanwagner
previously approved these changes
Nov 14, 2024
aboungnaseng-ovhcloud
force-pushed
the
feat/mrc-ods-version-18-3
branch
from
d1fb8c2
to
005cee1
Compare
tristanwagner
previously approved these changes
Nov 14, 2024
ref: MANAGER-14622 Signed-off-by: Alex Boungnaseng <[email protected]>
ref: MANAGER-14622 Signed-off-by: Alex Boungnaseng <[email protected]>
ref: MANAGER-14622 Signed-off-by: Alex Boungnaseng <[email protected]>
ref: MANAGER-14622 Signed-off-by: Alex Boungnaseng <[email protected]>
aboungnaseng-ovhcloud
force-pushed
the
feat/mrc-ods-version-18-3
branch
from
005cee1
to
d2e033c
Compare
anooparveti
requested changes
Nov 15, 2024
There was a problem hiding this comment.
Change of isDisabled to disabled is a breaking change IMO. So, we either need to mention it in Documentation or use the version v3.0.
Or we can ignore this change and keep disabled as is.
There was a problem hiding this comment.
Yes Its a breaking change but we wanted to be align with attribute name of ODS
There was a problem hiding this comment.
Okay, then add it in Documentation.
packages/manager-react-components/src/components/typography/links/links.component.tsx
Outdated
Show resolved
Hide resolved
aboungnaseng-ovhcloud
force-pushed
the
feat/mrc-ods-version-18-3
branch
from
d2e033c
to
fd69a4f
Compare
ref: MANAGER-14622 Signed-off-by: Alex Boungnaseng <[email protected]>
aboungnaseng-ovhcloud
force-pushed
the
feat/mrc-ods-version-18-3
branch
from
fd69a4f
to
52c77cb
Compare
|
anooparveti
approved these changes
Nov 15, 2024
tristanwagner
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterDescription
Bump ods version 18.3..0 and fix publish documentation
Related