Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(pci.rancher): change method for pricing (#14008)" #14126

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Revert "fix(pci.rancher): change method for pricing (#14008)" #14126

merged 1 commit into from
Nov 15, 2024

Conversation

Eric-ciccotti
Copy link
Contributor

@Eric-ciccotti Eric-ciccotti commented Nov 15, 2024 •
edited
Loading

Question Answer
Branch? release/public-cloud-w47
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #TAPC-2064
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

This PR reverts the commit : 830fd40

@Eric-ciccotti Eric-ciccotti requested a review from a team as a code owner November 15, 2024 14:41
@Eric-ciccotti Eric-ciccotti requested review from qpavy, darsene and mhelhali-soufien and removed request for a team November 15, 2024 14:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anooparveti anooparveti merged commit 3e3a076 into release/public-cloud-w47 Nov 15, 2024
22 of 23 checks passed
@anooparveti anooparveti deleted the revert/pci-rancher_fix-monthly-pricing_tapc-2064 branch November 15, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@ppprevost ppprevost ppprevost approved these changes

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Eric-ciccotti @ppprevost @fredericvilcot @anooparveti